armory / spinnaker-operator

Open Source Spinnaker Kubernetes Operator source code
Apache License 2.0
187 stars 70 forks source link

Operator have validation error in k8s 1.22 #274

Closed DodgeCamaro closed 1 year ago

DodgeCamaro commented 1 year ago

spinnaker-operator:1.3.0-rc.21 have errors Error from server (InternalError): error when creating "spin.yml": Internal error occurred: failed calling webhook "webhook-spinnakerservices-v1alpha2.spinnaker.io": failed to call webhook: Post "https://spinnaker-operator.spinnaker.svc:443/validate-spinnaker-io-v1alpha2-spinnakerservice?timeout=10s": context deadline exceeded

spinnaker-operator:1.2.5 have errors {"level":"error","ts":1663320321.5542288,"logger":"cmd","msg":"error starting webhook server","error":"the server could not find the requested resource","stacktrace":"github.com/go-logr/zapr.(*zapLogger).Error\n\t/opt/spinnaker-operator/build/vendor/github.com/go-logr/zapr/zapr.go:128\ngithub.com/armory/spinnaker-operator/pkg/operator.Start\n\t/opt/spinnaker-operator/build/pkg/operator/operator.go:138\nmain.main\n\t/opt/spinnaker-operator/build/cmd/manager/main.go:24\nruntime.main\n\t/usr/local/go/src/runtime/proc.go:203"}

wangycc commented 1 year ago

No support for k8s 1.22+? no one is handling it?

LukasdeBoer commented 1 year ago

Any progress here? EKS 1.21 is EOL on february 15th 2023 and Spinnaker not supporting 1.22 is a big problem when clusters are gonna be auto upgraded.

christosarvanitis commented 1 year ago

Workaround for the above issue:

brian-provenzano commented 1 year ago

We have the same issue trying to move to 1.22

What impact does this have on functionality? What does this webhook validate exactly?

christosarvanitis commented 1 year ago

Disabling the admission-controller basically disables the spinnakerservice custom resource validation against the CRD schema before applying it. So for example if you deploy a spinnakerservice manifest which doesnt follow the CRD schema the validation webhook will throw you an error before it applies it. Without the validationwebhook the manifest will be applied but then spinnaker-operator will throw errors for unknown properties etc

brian-provenzano commented 1 year ago

OK - so for clarification this is only for spinnaker related CRDs?

GenPage commented 1 year ago

Yes, any webhooks setup by the spinnaker-operator validate only Spinnaker CRDs created by the operator.

KshitijaR16 commented 1 year ago

Hi team,

Even we are facing issue for spinnaker-operator, with same error as mentioned above. @brian-provenzano is delete webhook and disable admission controller worked for you

sergio-quintero commented 1 year ago

Latest Operator 1.3.0 release has added support for K8s 1.22+.

K8s Compatibility Matrix

brian-provenzano commented 1 year ago

Hi team,

Even we are facing issue for spinnaker-operator, with same error as mentioned above. @brian-provenzano is delete webhook and disable admission controller worked for you

sorry, late on this, but "yes" it did