search

armory / spinnaker-operator

Open Source Spinnaker Kubernetes Operator source code
Apache License 2.0
187 stars 70 forks source link

feat(k8s): add support for GA ingress apiVersion in helm chart and operator #287

Closed nasonfish closed 1 year ago

nasonfish commented 1 year ago

Hi there,

We're currently noticing that this spinnaker operator creates an Ingress object of version extensions/v1beta1. This version is no longer supported by versions of Kubernetes v1.22+, as per this documentation.

This change implements what helm create templates out by default for Ingresses, allowing backwards-compatibility for folks using the old ingress version while allowing installation of the GA Ingress apiVersion (conditional on .Capabilities.KubeVersion.GitVersion).

In short: this should be a backwards-compatible change which allows installation of this operator on clusters running Kubernetes v1.22+.

nasonfish commented 1 year ago

hey there @jasonmcintosh -- you are absolutely right, this was missing some essential upgrades to the actual operator. It has now been updated to use the GA ingress version. it appears to be running successfully -- let me know if you have a chance to take a look at this again.

mrampton commented 1 year ago

Thanks for the work on this @nasonfish!