search

armory3d / armory

3D Engine with Blender Integration
https://armory3d.org/engine
zlib License
3.08k stars 319 forks source link

Nishita sky crashes when strength set to zero. #2937

Closed e2002e closed 1 year ago

e2002e commented 1 year ago

Thank you for contributing to Armory!

When using a nishita sky and setting the environment light to 0, crashes occur: double free or corruption (out) WARNING: Player exited code -6 . Blender: 3.6 Armory: lattest OS: PopOS Graphics card: rtx 3050 driver 535

MoritzBrueckner commented 1 year ago

Hi, I'm assuming the crash happens on Krom? I can't reproduce this and I'm a bit surprised that the crashes only seem to happen when you set the env strength to 0, as this only changes a shader uniform. However, there was an issue with Nishita skies in Krom builds that I fixed in https://github.com/armory3d/armorcore/pull/64, unfortunately this fix will not make it into the SDK until https://github.com/armory3d/armorcore/issues/63 gets fixed... Maybe check the fixes with a custom Krom build, if you know how to compile it.

rpaladin commented 1 year ago

If you created this issue as an intentionally misleading false report, just so you could nag for a code review, then that's rather despicable behavior on your part, in my opinion.

Please stop spamming unprepared pull-requests and false issue tracker reports.

e2002e commented 1 year ago

@rpaladin, no that is never my intention.

e2002e commented 1 year ago

I'm closing this since I can't reproduce the issue. I was quite sure that using a nishita sky with 0 strength would allow for a lit sky without the environment light. This doesn't hold true right now, don't know why. Sorry about the disturbancy.

e2002e commented 1 year ago

I'm reopening since this is still an issue. I tested the code again, with nvidia drivers 510, and the exit code is now -11.