search

armory3d / armory

3D Engine with Blender Integration
https://armory3d.org/engine
zlib License
3.08k stars 319 forks source link

play sound node: fix update routine version #2984

Closed t3du closed 11 months ago

t3du commented 11 months ago

fix version

MoritzBrueckner commented 11 months ago

Hi, this is still wrong because (0, 2) is a tuple, not a range. This means that now (with this PR merged), updating sound nodes with version 1 will cause a LookupError because 1 is not in (0, 2). I fixed it in https://github.com/armory3d/armory/commit/a67b5f5222007bf527a02544da3b78c3d249bfa6, this way you don't need to open another PR :)

t3du commented 11 months ago

thanks again! you're the best!