armory3d / armsdk

Single-clone Armory SDK
38 stars 30 forks source link

Add option to automatically decide amount of Khamake processes #51

Closed MoritzBrueckner closed 2 years ago

MoritzBrueckner commented 2 years ago

Requires https://github.com/Kode/khamake/pull/262.

This PR adds an option to the user preferences that lets Khamake choose the number of processes automatically if enabled. It's off by default for now since I can only test it on my rather old 4 core computer where the auto setting defaults to 3 processes and is slightly slower than manually specifying more processes. If more tests are made by other users we can probably enable it by default.

Screenshot

@luboslenco I'm wondering whether it's possible to move parts of the preferences out of the SDK into the armory submodule so that we no longer need all the hasattr() checks (see https://github.com/armory3d/armory/pull/2596) and we have less "separated" PRs. I'm not yet sure whether Blender allows to split the preferences into multiple files/classes while still saving them with one addon (we still need the SDK path setting to be in armory.py, for example), but if it turns out to be technically possible, what would you think of this?

luboslenco commented 2 years ago

but if it turns out to be technically possible, what would you think of this?

Yes, definitely!