Feature/namespaced profiles

Type

Enhancement

Description

Added support for namespaced profiles in the application. This includes changes in main.go and cache.go to include storeNamespace in various initializations and function calls.
Updated tests in cache_test.go to reflect the changes made for namespaced profiles.
Updated the kapprofiler dependency from v0.0.48 to v0.0.49 in go.mod and go.sum.
Made minor formatting changes in values.yaml.

Changes walkthrough

Relevant files

Configuration changes

main.go

Added namespace support in main.go

cmd/main.go - Added `storeNamespace` to the `ApplicationProfileK8sCache` and
`CollectorManagerConfig` initializations. - Added `storeNamespace` to the `NewController` initialization in the
`reconcilercontroller` package.

+3/-2

Enhancement

cache.go

Added namespace support in cache.go

pkg/approfilecache/cache.go - Added `storeNamespace` to the `ApplicationProfileK8sCache` struct and
its initialization. - Modified `generateApplicationProfileName` and
`getApplicationProfileNameParts` to consider `storeNamespace`. - Updated `LoadApplicationProfile` and `handleDeleteApplicationProfile`
to use `storeNamespace`.

+43/-9

Tests

cache_test.go

Updated cache tests with namespace support

pkg/approfilecache/cache_test.go - Updated `NewApplicationProfileK8sCache` initializations in tests to
include `storeNamespace`.

+2/-2

Formatting

values.yaml

Formatting changes in values.yaml

chart/kubecop/values.yaml - Removed some blank lines.

+0/-3

Dependencies

go.mod `Updated kapprofiler dependency in go.mod` go.mod - Updated the version of `github.com/kubescape/kapprofiler` from v0.0.48 to v0.0.49.	+1/-1
go.sum `Updated kapprofiler hashes in go.sum` go.sum - Updated the hash values for `github.com/kubescape/kapprofiler` due to version update.	+2/-2

✨ Usage guide:

**Overview:** The `describe` tool scans the PR code changes, and generates a description for the PR - title, type, summary, walkthrough and labels. The tool can be triggered [automatically](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) every time a new PR is opened, or can be invoked manually by commenting on a PR. When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L46) related to the describe tool (`pr_description` section), use the following template: ``` /describe --pr_description.some_config1=... --pr_description.some_config2=... ``` With a [configuration file](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-app), use the following template: ``` [pr_description] some_config1=... some_config2=... ```

Enabling\disabling automation

- When you first install the app, the [default mode](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) for the describe tool is: ``` pr_commands = ["/describe --pr_description.add_original_user_description=true" "--pr_description.keep_original_user_title=true", ...] ``` meaning the `describe` tool will run automatically on every PR, will keep the original title, and will add the original user description above the generated description. - Markers are an alternative way to control the generated description, to give maximal control to the user. If you set: ``` pr_commands = ["/describe --pr_description.use_description_markers=true", ...] ``` the tool will replace every marker of the form `pr_agent:marker_name` in the PR description with the relevant content, where `marker_name` is one of the following: - `type`: the PR type. - `summary`: the PR summary. - `walkthrough`: the PR walkthrough. Note that when markers are enabled, if the original PR description does not contain any markers, the tool will not alter the description at all.

Custom labels

The default labels of the `describe` tool are quite generic: [`Bug fix`, `Tests`, `Enhancement`, `Documentation`, `Other`]. If you specify [custom labels](https://github.com/Codium-ai/pr-agent/blob/main/docs/DESCRIBE.md#handle-custom-labels-from-the-repos-labels-page-gem) in the repo's labels page or via configuration file, you can get tailored labels for your use cases. Examples for custom labels: - `Main topic:performance` - pr_agent:The main topic of this PR is performance - `New endpoint` - pr_agent:A new endpoint was added in this PR - `SQL query` - pr_agent:A new SQL query was added in this PR - `Dockerfile changes` - pr_agent:The PR contains changes in the Dockerfile - ... The list above is eclectic, and aims to give an idea of different possibilities. Define custom labels that are relevant for your repo and use cases. Note that Labels are not mutually exclusive, so you can add multiple label categories. Make sure to provide proper title, and a detailed and well-phrased description for each label, so the tool will know when to suggest it.

Inline File Walkthrough 💎

For enhanced user experience, the `describe` tool can add file summaries directly to the "Files changed" tab in the PR page. This will enable you to quickly understand the changes in each file, while reviewing the code changes (diffs). To enable inline file summary, set `pr_description.inline_file_summary` in the configuration file, possible values are: - `'table'`: File changes walkthrough table will be displayed on the top of the "Files changed" tab, in addition to the "Conversation" tab. - `true`: A collapsable file comment with changes title and a changes summary for each file in the PR. - `false` (default): File changes walkthrough will be added only to the "Conversation" tab.

Utilizing extra instructions

The `describe` tool can be configured with extra instructions, to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Notice that the general structure of the description is fixed, and cannot be changed. Extra instructions can change the content or style of each sub-section of the PR description. Examples for extra instructions: ``` [pr_description] extra_instructions=""" - The PR title should be in the format: ': ' - The title should be short and concise (up to 10 words) - ... """ ``` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable. </details></td></tr> <tr><td><details> <summary><strong> More PR-Agent commands</strong></summary><hr> > To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \<QUESTION\>**: Ask a question about the PR. > - **/update_changelog**: Update the changelog based on the PR's contents. > - **/add_docs** 💎: Generate docstring for new components introduced in the PR. > - **/generate_labels** 💎: Generate labels for the PR based on the PR's contents. > - **/analyze** 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. >See the [tools guide](https://github.com/Codium-ai/pr-agent/blob/main/docs/TOOLS_GUIDE.md) for more details. >To list the possible configuration parameters, add a **/config** comment. </details></td></tr> </table> See the [describe usage](https://github.com/Codium-ai/pr-agent/blob/main/docs/DESCRIBE.md) page for a comprehensive guide on using this tool. </details> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/codiumai-pr-agent-free[bot]"><img src="https://avatars.githubusercontent.com/in/354216?v=4" />codiumai-pr-agent-free[bot]</a> commented <strong> 7 months ago</strong> </div> <div class="markdown-body"> <p><strong><a href="https://github.com/armosec/kubecop/pull/165">PR Description</a></strong> updated to latest commit (<a href="https://github.com/armosec/kubecop/commit/7c7ce0096c2e23d229b5e99b0f40bdb693d2dbf4">https://github.com/armosec/kubecop/commit/7c7ce0096c2e23d229b5e99b0f40bdb693d2dbf4</a>)</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/codiumai-pr-agent-free[bot]"><img src="https://avatars.githubusercontent.com/in/354216?v=4" />codiumai-pr-agent-free[bot]</a> commented <strong> 7 months ago</strong> </div> <div class="markdown-body"> <h2>PR Analysis</h2> <ul> <li>🎯 <strong>Main theme:</strong> Adding support for namespaced profiles</li> <li>📝 <strong>PR summary:</strong> This PR introduces support for namespaced profiles in the application. It modifies the <code>main.go</code> and <code>cache.go</code> files to include <code>storeNamespace</code> in various initializations and function calls. The PR also updates the tests in <code>cache_test.go</code> to reflect these changes. Additionally, the <code>kapprofiler</code> dependency is updated from v0.0.48 to v0.0.49.</li> <li>📌 <strong>Type of PR:</strong> Enhancement</li> <li>🧪 <strong>Relevant tests added:</strong> Yes</li> <li>⏱️ <strong>Estimated effort to review [1-5]:</strong> 3, because the PR involves changes in the core functionality of the application and requires understanding of the application's architecture and flow. The changes are not too complex but are spread across multiple files.</li> <li>🔒 <strong>Security concerns:</strong> No security concerns found <h2>PR Feedback</h2></li> </ul> <p><strong>💡 General suggestions:</strong> The code changes look good overall. However, it would be good to add more comments in the code explaining the purpose of the changes, especially in the <code>cache.go</code> file where the logic for handling namespaced profiles is implemented. This would make it easier for other developers to understand the changes.</p> <hr> <details> <summary><strong>✨ Usage guide:</strong></summary><hr> **Overview:** The `review` tool scans the PR code changes, and generates a PR review. The tool can be triggered [automatically](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) every time a new PR is opened, or can be invoked manually by commenting on any PR. When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L19) related to the review tool (`pr_reviewer` section), use the following template: ``` /review --pr_reviewer.some_config1=... --pr_reviewer.some_config2=... ``` With a [configuration file](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-app), use the following template: ``` [pr_reviewer] some_config1=... some_config2=... ``` <table><tr><td><details> <summary><strong> Utilizing extra instructions</strong></summary><hr> The `review` tool can be configured with extra instructions, which can be used to guide the model to a feedback tailored to the needs of your project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify the relevant sub-tool, and the relevant aspects of the PR that you want to emphasize. Examples for extra instructions: ``` [pr_reviewer] # /review # extra_instructions=""" In the 'general suggestions' section, emphasize the following: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ ``` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable. </details></td></tr> <tr><td><details> <summary><strong> How to enable\disable automation</strong></summary><hr> - When you first install PR-Agent app, the [default mode](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) for the `review` tool is: ``` pr_commands = ["/review", ...] ``` meaning the `review` tool will run automatically on every PR, with the default configuration. Edit this field to enable/disable the tool, or to change the used configurations </details></td></tr> <tr><td><details> <summary><strong> Auto-labels</strong></summary><hr> The `review` tool can auto-generate two specific types of labels for a PR: - a `possible security issue` label, that detects possible [security issues](https://github.com/Codium-ai/pr-agent/blob/tr/user_description/pr_agent/settings/pr_reviewer_prompts.toml#L136) (`enable_review_labels_security` flag) - a `Review effort [1-5]: x` label, where x is the estimated effort to review the PR (`enable_review_labels_effort` flag) </details></td></tr> <tr><td><details> <summary><strong> Extra sub-tools</strong></summary><hr> The `review` tool provides a collection of possible feedbacks about a PR. It is recommended to review the [possible options](https://github.com/Codium-ai/pr-agent/blob/main/docs/REVIEW.md#enabledisable-features), and choose the ones relevant for your use case. Some of the feature that are disabled by default are quite useful, and should be considered for enabling. For example: `require_score_review`, `require_soc2_ticket`, and more. </details></td></tr> <tr><td><details> <summary><strong> More PR-Agent commands</strong></summary><hr> > To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \<QUESTION\>**: Ask a question about the PR. > - **/update_changelog**: Update the changelog based on the PR's contents. > - **/add_docs** 💎: Generate docstring for new components introduced in the PR. > - **/generate_labels** 💎: Generate labels for the PR based on the PR's contents. > - **/analyze** 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. >See the [tools guide](https://github.com/Codium-ai/pr-agent/blob/main/docs/TOOLS_GUIDE.md) for more details. >To list the possible configuration parameters, add a **/config** comment. </details></td></tr> </table> See the [review usage](https://github.com/Codium-ai/pr-agent/blob/main/docs/REVIEW.md) page for a comprehensive guide on using this tool. </details> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/codiumai-pr-agent-free[bot]"><img src="https://avatars.githubusercontent.com/in/354216?v=4" />codiumai-pr-agent-free[bot]</a> commented <strong> 7 months ago</strong> </div> <div class="markdown-body"> <h2>PR Code Suggestions</h2> <table><thead><tr><th></th><th>Suggestions </th></tr></thead><tbody><tr><td><strong>possible issue</strong></td><td><table><tr><td> <details><summary>Handle potential errors when starting the app profile reconciler controller. </summary> ___ **Consider handling the error from `appProfileReconcilerController.StartController()` to <br> ensure that the controller starts successfully.** [cmd/main.go [332]](https://github.com/armosec/kubecop/pull/165/files#diff-c444f711e9191b53952edb65bfd8c644419fc7695c62611dc0fb304b4fb197d6R332-R332) ```diff -appProfileReconcilerController.StartController() +if err := appProfileReconcilerController.StartController(); err != nil { + log.Fatalf("Failed to start app profile reconciler controller: %v\n", err) +} ``` </details></td></tr></table></td></tr><tr><td><strong>bug</strong></td><td><table><tr><td> <details><summary>Prevent index out of range errors in <code>getApplicationProfileNameParts</code>.</summary> ___ **Ensure that the `getApplicationProfileNameParts` function correctly handles cases where <br> the application profile name does not follow the expected format, to prevent index out of <br> range errors.** [pkg/approfilecache/cache.go [72]](https://github.com/armosec/kubecop/pull/165/files#diff-3a4db7494fb34330bd37c1021f0699c7cb08ce3e64703f19234ebb160ee996cdR72-R72) ```diff -kind, workloadName = strings.Split(appProfileUnstructured.GetName(), NameSeperator)[KindIndex], strings.Join(strings.Split(appProfileUnstructured.GetName(), NameSeperator)[WorkloadNameIndex:], NameSeperator) +parts := strings.Split(appProfileUnstructured.GetName(), NameSeperator) +if len(parts) > WorkloadNameIndex { + kind, workloadName = parts[KindIndex], strings.Join(parts[WorkloadNameIndex:], NameSeperator) +} else { + // Handle error or unexpected format +} ``` </details></td></tr></table></td></tr><tr><td><strong>enhancement</strong></td><td><table><tr><td> <details><summary>Ensure <code>storeNamespace</code> is not empty before using it in the application profile name.</summary> ___ **Consider adding a check to ensure `storeNamespace` is not empty before appending it to the <br> application profile name in `generateApplicationProfileName`.** [pkg/approfilecache/cache.go [54]](https://github.com/armosec/kubecop/pull/165/files#diff-3a4db7494fb34330bd37c1021f0699c7cb08ce3e64703f19234ebb160ee996cdR54-R54) ```diff -return strings.ToLower(kind) + NameSeperator + workloadName + NameSeperator + namespace +profileName := strings.ToLower(kind) + NameSeperator + workloadName +if namespace != "" { + profileName += NameSeperator + namespace +} +return profileName ``` </details></td></tr><tr><td> <details><summary>Add test cases for scenarios with non-empty <code>storeNamespace</code>. </summary> ___ **Consider adding more test cases to cover scenarios where `storeNamespace` is not empty, to <br> ensure the functionality works as expected in different configurations.** [pkg/approfilecache/cache_test.go [72]](https://github.com/armosec/kubecop/pull/165/files#diff-3a238726cc799f1d06e5adf4099c161770555edb84017963c781ef170ec1bf8dR72-R72) ```diff -cache, err := NewApplicationProfileK8sCache(dynamicClient, "") +// Example test case with non-empty storeNamespace +cache, err := NewApplicationProfileK8sCache(dynamicClient, "testNamespace") +// Additional test logic to verify behavior with non-empty storeNamespace ``` </details></td></tr></table></td></tr><tr><td><strong>best practice</strong></td><td><table><tr><td> <details><summary>Add a timeout to dynamic client resource get calls to avoid potential hangs. </summary> ___ **Use a context with a timeout or deadline for `cache.dynamicClient.Resource(...).Get(...)` <br> calls to avoid potential hangs in network communication.** [pkg/approfilecache/cache.go [119]](https://github.com/armosec/kubecop/pull/165/files#diff-3a4db7494fb34330bd37c1021f0699c7cb08ce3e64703f19234ebb160ee996cdR119-R119) ```diff -appProfile, err := cache.dynamicClient.Resource(collector.AppProfileGvr).Namespace(searchNamespace).Get(context.TODO(), cache.generateApplicationProfileName(ownerKind, ownerName, namespace), metav1.GetOptions{}) +ctx, cancel := context.WithTimeout(context.Background(), 30*time.Second) +defer cancel() +appProfile, err := cache.dynamicClient.Resource(collector.AppProfileGvr).Namespace(searchNamespace).Get(ctx, cache.generateApplicationProfileName(ownerKind, ownerName, namespace), metav1.GetOptions{}) ``` </details></td></tr></table></td></tr></tr></tbody></table><hr> <details> <summary><strong>✨ Usage guide:</strong></summary><hr> **Overview:** The `improve` tool scans the PR code changes, and automatically generates suggestions for improving the PR code. The tool can be triggered [automatically](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) every time a new PR is opened, or can be invoked manually by commenting on a PR. When commenting, to edit [configurations](https://github.com/Codium-ai/pr-agent/blob/main/pr_agent/settings/configuration.toml#L69) related to the improve tool (`pr_code_suggestions` section), use the following template: ``` /improve --pr_code_suggestions.some_config1=... --pr_code_suggestions.some_config2=... ``` With a [configuration file](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#working-with-github-app), use the following template: ``` [pr_code_suggestions] some_config1=... some_config2=... ``` <table><tr><td><details> <summary><strong> Enabling\disabling automation </strong></summary><hr> When you first install the app, the [default mode](https://github.com/Codium-ai/pr-agent/blob/main/Usage.md#github-app-automatic-tools) for the improve tool is: ``` pr_commands = ["/improve --pr_code_suggestions.summarize=true", ...] ``` meaning the `improve` tool will run automatically on every PR, with summarization enabled. Delete this line to disable the tool from running automatically. </details></td></tr> <tr><td><details> <summary><strong> Utilizing extra instructions</strong></summary><hr> Extra instructions are very important for the `improve` tool, since they enable to guide the model to suggestions that are more relevant to the specific needs of the project. Be specific, clear, and concise in the instructions. With extra instructions, you are the prompter. Specify relevant aspects that you want the model to focus on. Examples for extra instructions: ``` [pr_code_suggestions] # /improve # extra_instructions=""" Emphasize the following aspects: - Does the code logic cover relevant edge cases? - Is the code logic clear and easy to understand? - Is the code logic efficient? ... """ ``` Use triple quotes to write multi-line instructions. Use bullet points to make the instructions more readable. </details></td></tr> <tr><td><details> <summary><strong> A note on code suggestions quality</strong></summary><hr> - While the current AI for code is getting better and better (GPT-4), it's not flawless. Not all the suggestions will be perfect, and a user should not accept all of them automatically. - Suggestions are not meant to be simplistic. Instead, they aim to give deep feedback and raise questions, ideas and thoughts to the user, who can then use his judgment, experience, and understanding of the code base. - Recommended to use the 'extra_instructions' field to guide the model to suggestions that are more relevant to the specific needs of the project, or use the [custom suggestions :gem:](https://github.com/Codium-ai/pr-agent/blob/main/docs/CUSTOM_SUGGESTIONS.md) tool - With large PRs, best quality will be obtained by using 'improve --extended' mode. </details></td></tr> <tr><td><details> <summary><strong> More PR-Agent commands</strong></summary><hr> > To invoke the PR-Agent, add a comment using one of the following commands: > - **/review**: Request a review of your Pull Request. > - **/describe**: Update the PR title and description based on the contents of the PR. > - **/improve [--extended]**: Suggest code improvements. Extended mode provides a higher quality feedback. > - **/ask \<QUESTION\>**: Ask a question about the PR. > - **/update_changelog**: Update the changelog based on the PR's contents. > - **/add_docs** 💎: Generate docstring for new components introduced in the PR. > - **/generate_labels** 💎: Generate labels for the PR based on the PR's contents. > - **/analyze** 💎: Automatically analyzes the PR, and presents changes walkthrough for each component. >See the [tools guide](https://github.com/Codium-ai/pr-agent/blob/main/docs/TOOLS_GUIDE.md) for more details. >To list the possible configuration parameters, add a **/config** comment. </details></td></tr> </table> See the [improve usage](https://github.com/Codium-ai/pr-agent/blob/main/docs/IMPROVE.md) page for a more comprehensive guide on using this tool. </details> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/github-actions[bot]"><img src="https://avatars.githubusercontent.com/in/15368?v=4" />github-actions[bot]</a> commented <strong> 7 months ago</strong> </div> <div class="markdown-body"> <p>:sparkles: Artifacts are available <a href="https://github.com/armosec/kubecop/actions/runs/7806630081">here</a>.</p> </div> </div> <div class="comment"> <div class="user"> <a rel="noreferrer nofollow" target="_blank" href="https://github.com/github-actions[bot]"><img src="https://avatars.githubusercontent.com/in/15368?v=4" />github-actions[bot]</a> commented <strong> 7 months ago</strong> </div> <div class="markdown-body"> <p>:sparkles: Artifacts are available <a href="https://github.com/armosec/kubecop/actions/runs/7807297085">here</a>.</p> </div> </div> <div class="page-bar-simple"> </div> <div class="footer"> <ul class="body"> <li>© <script> document.write(new Date().getFullYear()) </script> Githubissues.</li> <li>Githubissues is a development platform for aggregating issues.</li> </ul> </div> <script src="https://cdn.jsdelivr.net/npm/jquery@3.5.1/dist/jquery.min.js"></script> <script src="/githubissues/assets/js.js"></script> <script src="/githubissues/assets/markdown.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/highlight.min.js"></script> <script src="https://cdn.jsdelivr.net/gh/highlightjs/cdn-release@11.4.0/build/languages/go.min.js"></script> <script> hljs.highlightAll(); </script> </body> </html>

armosec / kubecop