search

armpatch / TrainingLog

Android app for tracking workouts
3 stars 3 forks source link

Improve number chooser #29

Closed ir31k0 closed 4 years ago

ir31k0 commented 4 years ago

I created an abstract number chooser and add two implementations. One for integers and one for floating point numbers. Additionally, I update the measurement fields (measurement1 to weight and measurement2 to repetition). The type of repetition is an INTEGER now. So repetitions will be shown as integer.

I noticed that you've been planning other types in the future. In my opinion, the best idea would be to create an abstract table for all basic data and another table for each type.

armpatch commented 4 years ago

I noticed that you've been planning other types in the future. In my opinion, the best idea would be to create an abstract table for all basic data and another table for each type.

Originally I was planning on adding other types, but I may just keep it to weight and repetitions for this project.

I like the way you cleaned this up. Thank you!