search

arn-the-long-beard / seed-routing

Prototype for having easy routing to use in Seed
MIT License
6 stars 2 forks source link

ci: run tests without installing cargo-make #10

Closed Ben-PH closed 3 years ago

Ben-PH commented 3 years ago

cargo-make adds overhead to the CI run, and can be replaced by constructing the commands manually in the ci file.

arn-the-long-beard commented 3 years ago

Fixed the build with https://github.com/arn-the-long-beard/seed-routing/commit/f2f28a24f296d477132b270d2a5ffb551b40dfeb

arn-the-long-beard commented 3 years ago

Yes ! :smile: Now I was using cargo make on my machine because seed uses it also. So I thought that having the same config is a good idea for simplicity sake. We can of course run the test in github without it so it is faster :+1:

Now I know that seed is planning to move from cargo-make to trunk which seems to be more specialized.

So maybe we can keep this in mind also for the future :wink:

Good work again :+1: