search

arn-the-long-beard / seed-routing

Prototype for having easy routing to use in Seed
MIT License
6 stars 2 forks source link

native history navigation does not work #25

Open arn-the-long-beard opened 3 years ago

arn-the-long-beard commented 3 years ago

Hello guys,

Well I am not sure why but when I use the native history navigation from the web browser, I get the url back as it is supposed to do, but pages does not render as it should be.

So for now I do not know where the bugs come from yet. Maybe this could be a good opportunity to actually change the internal cuisine for the router and use directly the native apis with web_sys,

arn-the-long-beard commented 3 years ago

Okay it seems, we do not get anymore the event subs::UrlRequested when using back and forward button on the navigator from Seed.

arn-the-long-beard commented 3 years ago

Might be we never got it from our discussion on Discord. SO it seems we have to change when we use confirm_navigation , but the way it is made now is correct and make sens or make a PR to Seed.

I think make a PR is the best.