search

arn7av / esl-facebook-stream

ESL Facebook stream client
https://esl.atx.sx
MIT License
27 stars 7 forks source link

Fullscreen video goes halfway offscreen #3

Open blaberry opened 6 years ago

blaberry commented 6 years ago

The fullscreen Dash player seems to have some issues when the control bar goes off screen. Didn't happen before dark mode was implemented.

MBPr, 2017 model. Chrome Canary Version 68.0.3398.0

screen shot 2018-05-18 at 22 55 24
arn7av commented 6 years ago

@blaberry I have heard that issue before, and I was surprised it was fixed for them after they restarted their MBP. Can you give it a full restart aswell, and get back with the result?

blaberry commented 6 years ago

No dice, persists across reboots unfortunately

arn7av commented 6 years ago

@blaberry noted. While working for Theatre Mode, we will need to fix a lot of CSS issues w.r.t. grids and placements to fix the controlbar misbehaving in lot of scenarios. I am pondering on rewriting the full player using flexbox (the chat part is already written in flexbox after I found it was misbehaving in past). I am certain that the rewrite will fix these pesky issues aswell. Thanks a lot for reporting!

blaberry commented 6 years ago

No problems, good luck!

arn7av commented 6 years ago

@blaberry it probably is fixed in https://github.com/arn7av/esl-facebook-stream/commit/5515be8dbad429b45204c373213a9492d848dfd3#diff-a4deaa0cd1a53c0cfe42859d99b7daa8R134. Would be awesome if you can give it a shot, and report back!