Open BlackKite84 opened 9 years ago
Hi @BlackKite84 can you produce a jsfiddle with the problem?
Huh, I am missing something here. You specified (in that jsfiddle):
originalContainer
as .updateOriginal
changedContainer
and diffContainer
as .updateChange
Dog Days''
)Questions:
diffContainer
is same as the changedContainer
)?Also, the "title" of this issue is set to <br>
. Could you please change that to the actual problem/question you are reporting/asking?
I overwrite the change Content with the diff (i will see only change and original)
http://jsfiddle.net/pytm9ueL/2/
A new line (
)
Add debug: true
to when you call prettyTextDiff
: http://jsfiddle.net/pytm9ueL/4/
This will show you what this library found. Looks like the underlying Google diff-match-patch
library shows the "↵ "
also as a diff.
and why "Enter" i use Tab
Like I said, what you are seeing is coming from the underlying library. Please ask your question there: https://code.google.com/p/google-diff-match-patch/
I have Fix ist with
} else {
original = $(settings.originalContainer, this).text().trim();
changed = $(settings.changedContainer, this).text().trim();
}
I am running into the same issue that @BlackKite84 was seeing. I have two divs that appear to have identical content (including whitespace). If I pass parameters via originalContainer and changedContainer, PrettyTextDiff appears to pass slightly different strings (different in their whitespace) to google-diff-match-patch. Here is the result of a call to .prettyTextDiff( ) when I use originalContainer and changedContainer parameters. Note the <br>
's that are inserted at the beginning and end of .immutable-clause-pretty-diff
And here is the result of a call to .prettyTextDiff( ) when I use originalContent and changedContent parameters with the trim( ) function, as suggested by @BlackKite84. It works as expected:
It appears that if there are matching newline characters inside the originalContent and changedContent divs, google-diff-match-patch passes the newline character back, but PrettyTextDiff converts said newline character to a <br>
here
I'm not sure if it would break things for other users, but it seems like substituting <br>
s for newline characters may not be necessary.
I think that any problems like \t
, \b
, or whitespace would be solved by using <pre></pre>
Example: https://jsfiddle.net/ybz8enwk
on Diff by Two Table withs Tab's the output has a
what does not belong there
output (updateChange) the
before Dog Days is too much
on view in browser i See a new line, the Text is not symmetric on line beginning