arnabwahid / wordpress-bootstrap

Bootstrap in WordPress theme form - Bootstrap 3.3.1
1.49k stars 556 forks source link

Drop-down menu on Ipad not working #113

Open awhedbee22 opened 11 years ago

awhedbee22 commented 11 years ago

The drop-down navigation when the ipad is in landscape drops down but the pages are unclickable. When you click on one it does nothing. I have tested it on my site along with http://320press.com/wpbs/

Thank you, AW

noahbass commented 11 years ago

this jquery in the footer fixed it for me testing on my ipad and ios simulator:

$('body').on('touchstart.dropdown', '.dropdown-menu', function (e) {
e.stopPropagation();
}

I found this solution on a bootstrap issue, cannot remember which one. There is a big thread about it on the bootstrap repo though.

chrisbarnes commented 11 years ago

Are people still seeing this issue?

noahbass commented 11 years ago

here is an issue thread thing with a couple of solutions that I mentioned a month ago: https://github.com/twitter/bootstrap/issues/4550#issuecomment-8264129

another solution that seems to work: https://github.com/twitter/bootstrap/issues/4550#issuecomment-8447095

Although this issue was said by the bootstrap team to be be fixed in one of the updates, it still seems that it must be patched up with one of these solutions.

chrisbarnes commented 11 years ago

Thanks. Looks like 2.3.2 (that they just pushed friday) fixes this. I'll update the version of bootstrap we use here to that.

On Mon, May 20, 2013 at 10:52 AM, Noah notifications@github.com wrote:

here is an issue thread thing with a couple of solutions that I mentioned a month ago: twitter/bootstrap#4550https://github.com/twitter/bootstrap/issues/4550#issuecomment-8264129

— Reply to this email directly or view it on GitHubhttps://github.com/320press/wordpress-bootstrap/issues/113#issuecomment-18151559 .

noahbass commented 11 years ago

Hopefully their changelog is correct for the 2.3.2 update. I have not gotten to play around with it yet. we will see.

aitala commented 11 years ago

I've tried the various patches and so far none have seemed to work...

E

noahbass commented 11 years ago

Just tested the new 2.3.2 update on the ios simulator and my ipad with this dropdown and this one, both are having no issues with the navigation at the moment.

Futhermore, the dropdowns on [320press.com/wpbs](http://320press.com/wpbs/] are not working, (thats bootstrap version 2.1.1 I believe) and the dropdowns on the bootstrap 2.1.1 demo site are not working.

It looks like work with the bootstrap-dropdown.js by the team did the job: https://github.com/twitter/bootstrap/commit/b9bd82b49656e320b623cc3e2c0363c1ffb9e9ad#L1R55

aitala commented 11 years ago

I just tried the two links in the first paragraph above on my iPhone and none of the links in the drop down menu were clickable.

noahbass commented 11 years ago

@aitala very interesting.... I'll take another look later tonight. I've been sidetracked by this all this afternoon. Gotta study for my exams. Less code, more study in this situation.

Anyway, I'll check it out again soon.

noahbass commented 11 years ago

@aitala - Yes, those links I sent have this bit of code as their link:

<li><a href="#">link</a></li>

for demostration purposes instead of a normal page:

<li><a href="/link">link</a></li>

Therefore, in these example pages, the links do not do anything. Hopefully this is the issue you are seeing. Please check http://320press.com/wpbs/ and see if you can see the issue there as well. My testing with the simulator says that the navigation works okay on the iphone on http://320press.com/wpbs/

aitala commented 11 years ago

I know about the null '#' links on most of the demo pages and those are not working. I've also looked at the theme switcher links on the Bootswatch site on an iPad and iPod and those do not work in portrait mode either.

It does appear that the links within the dropdowns on http://320press.com/wpbs/ are working on my iPad- now I wish I knew why.... (I guess b/c you are using Bootstrap 2.1.1? If so I may revert to that for my site)

noahbass commented 11 years ago

@aitala - I'm going to speculate its a version issue and will be working once people update the version of bootstrap on their projects.

aitala commented 11 years ago

See https://github.com/twitter/bootstrap/issues/4550#issuecomment-18183089

noahbass commented 11 years ago

@aitala - wow, looks like the update did not work for most. Surely one of the solutions listed there worked for you?

aitala commented 11 years ago

@noahbass Reverting to the 2.2.1 version of bootstrap-dropdown.js plus the patch seems to be working. Looks like it will need an update, see https://github.com/Bitergia/bootstrap/commit/25e8eeb47f01aceed57cb2715036a69395892fa8

noahbass commented 11 years ago

@aitala great to hear a fix. The community over here will have to keep a look out for things like this in the future.

FloNeu commented 11 years ago

Will this issue be closed with the next version? Found it appearing in my application today... will try the fixes. ty

kingb commented 11 years ago

Is it just me, or did the issue with the fixes disappear when the repo moved to github.com/twbs/?

byazdan commented 11 years ago

Hi, I'm using 2.3.2 and am having this issue as well. None of the links above seem to be working so I can't find the fix. Help! Thanks