arnaucube / go-snark-study

zkSNARK library implementation in Go from scratch (compiler, setup, prover, verifier)
GNU General Public License v3.0
255 stars 57 forks source link

follow whitespace rule of strings.TrimSpace #14

Closed KimiWu123 closed 4 years ago

KimiWu123 commented 4 years ago

it's related to #13 compilation error on Windows.

Root cause: Didn't treat \r as part of white space in isWhitespace of lexer.go

Solution: Follow golang function strings.TrimSpace, filter out \r, \v, \f

arnaucube commented 4 years ago

Cool! I've implemented using Linux, so I didn't tested on other operating systems. Thanks for the PR :)