arnaud-jamin / Cog

Cog is a set of debug tools for Unreal Engine built on top of Dear ImGui
MIT License
357 stars 44 forks source link

Fix compling errors on various platforms/consoles #17

Closed HoussineMehnik closed 11 months ago

HoussineMehnik commented 11 months ago
arnaud-jamin commented 11 months ago

Thanks a lot for this contribution!

arnaud-jamin commented 11 months ago

I integrated everything but the first change I commented above. (#include "CogDebugSettings.h") Don't hesitate to tell me if this is still causing an error. Thanks !!!

HoussineMehnik commented 11 months ago

Cool! Tested with your change and everything works fine :)

HoussineMehnik commented 11 months ago

I just found that I have a local modification on CogCommon.Build.cs this is why I didn't got any issue with including "CogDebugSettings.h". "CogCommon" need to have a dependency to "CogDebug" , otherwise the build will fail on non unity builds.

arnaud-jamin commented 11 months ago

Could you copy paste the compiler error ? Thanks

HoussineMehnik commented 11 months ago

"fatal error C1083: Cannot open include file: 'CogDebugSettings.h': No such file or directory"

But it disappeared again, I think there is something wrong with our build/validation configuration :)

arnaud-jamin commented 11 months ago

Do you know this error happens when compiling what file ? It is in the sample or a modified version ? CogDebugSettings.h should always be inside #if ENABLE_COG

HoussineMehnik commented 11 months ago

Oh nvm , sorry I didn't pay attention to it, CogDebugSettings.h was outside of #if ENABLE_COG 😅

arnaud-jamin commented 11 months ago

Ok cool. I know it is not intuitive as cog modules don't do that. But they get stripped instead.