search

arnaud-lb / MtHaml

Multi target HAML (HAML for PHP, Twig, <your language here>)
Other
359 stars 54 forks source link

Make Executor::compile public. #86

Closed pwhelan closed 9 years ago

pwhelan commented 9 years ago

rename Executor::compileFile as compile and make it public so it can be used to precompile MtHaml templates, ie: for deploying to GAE.

arnaud-lb commented 9 years ago

Thanks @pwhelan

Could we instead have a warmup($file) method that call compileFile($file) and return nothing ? I think that this would make the intent clearer.

pwhelan commented 9 years ago

@arnaud-lb no problem.

arnaud-lb commented 9 years ago

Thanks!

pwhelan commented 9 years ago

There were some build errors on Travis CI but I was unable to reproduce them locally. I can take another look a little later, but if you can think of anything off the top of your head that would be great.