search

arnaud-lb / MtHamlBundle

Symfony2 HAML bundle
38 stars 13 forks source link

Fixed typos and changed the way of registration for MtHaml #14

Closed hason closed 10 years ago

hason commented 10 years ago

Fixes #13

roman-yarovoy commented 10 years ago

Thanks for this patch. Original package doesn't works for me without it.

arnaud-lb commented 10 years ago

Thanks @hason. Could you explain why and when this change is needed?

roman-yarovoy commented 10 years ago

For example, I'm getting a

ServiceCircularReferenceException: Circular reference detected for service "twig", path: "twig -> spy_timeline.twig.extension.timeline -> twig"

exception without patch (some conflict with SpyTimelineBundle).

hason commented 10 years ago

@arnaud-lb Because the interface Twig_LexerInterface is deprecated and the class MtHamlBundle\Twig\Lexer doesn't support templates (https://github.com/arnaud-lb/MtHaml#integration-in-twig):

{% haml %}
%h1= title
arnaud-lb commented 10 years ago

Merged, thanks!