arnaud-lb / MtHamlBundle

Symfony2 HAML bundle
38 stars 13 forks source link

Recent update causes assetic:dump to stop working #15

Closed gentisaliu closed 10 years ago

gentisaliu commented 10 years ago

I ran into the problem as I updated the bundle to the latest version that the command

 sudo php app/console assetic:dump --env=prod --no-debug

stopped working as it was no longer dumping any assets. The last working version I used was commit 22116fb, to which I am going to revert as of now. As of 780473b, the issue appears.

Unfortunately I don't have much time to find a workaround/solution to this problem, since I have some strict deadlines to maintain...

See this SO question for more details: http://stackoverflow.com/questions/24339648/symfony2-assetic-is-not-dumping-any-assets/24340106#24340106

arnaud-lb commented 10 years ago

Thanks for the report.

Assetic's TwigFormulaLoader lexes Twig templates to find formulas. Since 780473b, we do not hook into the Lexer anymore, so the HAML to Twig conversion doesn't occur anymore here.

We could create a MtHamlFormulaLoader, but I wonder how many libs use the Lexer like this.

@hason, WDYT ?

arnaud-lb commented 10 years ago

Fixed by #16