arnaud-lb / php-memory-profiler

Memory profiler for PHP. Helps finding memory leaks in PHP scripts.
MIT License
870 stars 51 forks source link

initial work for ZTS build... #7

Closed remicollet closed 4 years ago

remicollet commented 11 years ago

Quite a big one.

At least, it allow to build the extension. Only minimal test run.

arnaud-lb commented 11 years ago

Awesome

There will be a limitation in ZTS however, as we cannot override zend_execute_fn / zend_execute_internal during script execution without affecting scripts running in other threads. In ZTS mode we will have to override them permanently (in MINIT), and add a is_enabled() check in memprof_zend_execute / memprof_zend_execute_internal.

weltling commented 11 years ago

The patch behaves ok at least with the console test, tested with PHP 5.4 yet.

mcarbonneaux commented 12 months ago

Awesome

There will be a limitation in ZTS however, as we cannot override zend_execute_fn / zend_execute_internal during script execution without affecting scripts running in other threads. In ZTS mode we will have to override them permanently (in MINIT), and add a is_enabled() check in memprof_zend_execute / memprof_zend_execute_internal.

there a solution to that ? a pull request on php-src ?