arnaud-lb / vim-php-namespace

PHP namespace support for VIM. Types "use" statements for you
256 stars 29 forks source link

add detection of php5.4 traits 'use' syntax #3

Closed docteurklein closed 12 years ago

docteurklein commented 12 years ago

Tests pass: yes. Retro compatible: yes

Until this fix, generated use statements were appended to last use keyword seen in the file, which could be a trait's use statement.

Now it only add generated use statements outside the class.

Also, you now can add use statements for traits too.

arnaud-lb commented 12 years ago

Thanks!

Apparently some tests are not passing anymore here, could you check ? Could you add a new test for this bug ? (see https://github.com/arnaud-lb/vim-php-namespace/blob/master/tests/README.markdown )

docteurklein commented 12 years ago

Hello!

Can you give me the output of the make command please ? All tests are passing locally on the "traits" branch. In any case I will add tests for this, thanks :)

EDIT: my bad, there are indeed 3 tests that do not pass:


Test results:
test-basic-14 FAILED
test-basic-4 FAILED
test-basic-6 FAILED
TEST FAILURE

EDIT: fixed

docteurklein commented 12 years ago

which makes tests pass, and behaves like we want! @arnaud-lb

arnaud-lb commented 12 years ago

Thanks!