arnaudcoquelet / fusionpbx

Automatically exported from code.google.com/p/fusionpbx
0 stars 0 forks source link

Selecting standard ringback in a queue will break it. #589

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1.Add a queue
2.Choose for example us-ring as hold music
3.Call the queue

What is the expected output? What do you see instead?
Expect us-ringback, Call fails with:-
2014-04-30 16:45:25.190352 [ERR] mod_native_file.c:74 Error opening 
/usr/local/freeswitch/sounds/en/us/callie/${uk-ring}.PCMU

What version of the product are you using? On what operating system?
3.5dev on Debian wheezy

Please provide any additional information below.

I had a fix for this before, but I can't remember it. I think it should use 
tone stream rather than local stream.

Original issue reported on code.google.com by Digitald...@gmail.com on 30 Apr 2014 at 3:50

GoogleCodeExporter commented 9 years ago
I have just checked and FusionPBX writes:

<param name="moh-sound" value="${uk-ring}"/>

into callcenter.conf.xml.

Replacing with this works:

<param name="moh-sound" value="tone_stream://$${uk-ring};loops=-1"/>

Original comment by Digitald...@gmail.com on 30 Apr 2014 at 4:03

GoogleCodeExporter commented 9 years ago
Implemented proposed fix in r6043.

Original comment by sevenate on 13 Jun 2014 at 5:57

GoogleCodeExporter commented 9 years ago
I don't read PHP too well but:

if (strlen($queue_moh_sound) == 0) {
$v_queues .= " <param name=\"moh-sound\" value=\"local_stream://default\"/>\n";
}
else {
$v_queues .= " <param name=\"moh-sound\" 
value=\"tone_stream://$".$queue_moh_sound.";loops=-1\"/>\n";
}

Is that else statement not going to mess up custom moh where another category 
is selected?

Original comment by Digitald...@gmail.com on 23 Jun 2014 at 5:29