arnaudcoquelet / fusionpbx

Automatically exported from code.google.com/p/fusionpbx
0 stars 0 forks source link

Time Conditions - If using presets, doesn't retain primary destination #876

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Create a time condition
2. Under presets choose New Year's Day (I tested using different combinations) 
and set a destination.
3. Set an alternate destination and click Save

What is the expected output? What do you see instead?

Expected output should be all the settings saving. Instead under presets it 
changes the destination back to Select Destination.

What version of the product are you using? On what operating system?
FusionPBX revision 7933
Debian 7

Please provide any additional information below.

Original issue reported on code.google.com by g1itchn...@gmail.com on 9 Mar 2015 at 8:39

GoogleCodeExporter commented 9 years ago
I can also reproduce it if I am setting a custom condition and I set the 
destination to a recording, a time condition, or anything under other.

Original comment by g1itchn...@gmail.com on 9 Mar 2015 at 9:07

GoogleCodeExporter commented 9 years ago
The first issue you mentioned is actually by design (though perhaps lacks some 
clarity).  Please see the attached screen capture.  The destination select box 
(at the bottom of the Presets row) only serves as a means to quickly set the 
explicit destinations for ALL presets checked above it.  If you click on a 
preset name, additional controls are displayed that allow you to explicitly 
define the destination for each preset (as well as add additional custom 
conditions, if desired).  In other words, if you simply check some presets, and 
then select a destination at the very bottom (below the list of presets), the 
destination you choose will be explicitly assigned (upon submission) to each 
preset you checked.  You can verify this on edit by clicking the names of the 
presets you checked, and looking at their individual destinations.

Concerning the second issue, this worked just fine at one time.  Will look into 
it.

Original comment by sevenate on 15 Mar 2015 at 10:02

Attachments:

GoogleCodeExporter commented 9 years ago
The first issue I did eventually find was working as intended, although as a 
new user to Fusion I agree it is lacking clarity. Perhaps the presets could be 
expanded by default if they have a value set? Or maybe a heading could be added 
to the Select Destination drop down box that says "Bulk edit" or something 
similar?

I think the second issue may be more of a clarity issue as well. I checked my 
custom destination and while it does look like it is not set. If I click the 
arrow to the right it shows my original destination. See both screenshots 
attached.

Original comment by g1itchn...@gmail.com on 15 Mar 2015 at 4:07

Attachments:

GoogleCodeExporter commented 9 years ago
Thanks for the input.  Yeah (on the second issue), really needs to display the 
custom condition in the select box (at the top, or something) OR initially 
display an input field if a custom destination is in place.  Will look into it.

Original comment by sevenate on 16 Mar 2015 at 8:51

GoogleCodeExporter commented 9 years ago
Believe 'second issue' resolved with r7982.  Clarity also added to Preset 
description in r7983.  

Please update and verify full/expected functionality.  Thanks.

Original comment by sevenate on 18 Mar 2015 at 5:25

GoogleCodeExporter commented 9 years ago
Updated to r7991. Confirming issue is fixed and better clarified.

Original comment by g1itchn...@gmail.com on 18 Mar 2015 at 1:50