search

arnaudleclerc / AzureMapsControl.Components

Razor Components for azure-maps-control
MIT License
34 stars 12 forks source link

Enrich expression API #71

Closed mitikov closed 2 years ago

mitikov commented 2 years ago

Adding primitive APIs to reduce the volume of boilerplate code to be written while working with expressions.

Inspired by #70

mitikov commented 2 years ago

@arnaudleclerc Could you please review?

Thanks.

codecov-commenter commented 2 years ago

Codecov Report

Merging #71 (bccadbc) into develop (8393100) will not change coverage. The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop      #71   +/-   ##
========================================
  Coverage    86.45%   86.45%           
========================================
  Files          124      124           
  Lines         3655     3655           
========================================
  Hits          3160     3160           
  Misses         495      495
Flag Coverage Δ
unittests 86.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rc/AzureMapsControl.Components/Atlas/Expression.cs 96.15% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8393100...bccadbc. Read the comment docs.

arnaudleclerc commented 2 years ago

@mitikov Thanks for the PR, this is a great improvement! Everything looks fine.

Do you think it is possible to add some unit tests on the new code ?

mitikov commented 2 years ago

@arnaudleclerc Sure, here you go :)

arnaudleclerc commented 2 years ago

Awesome, thank you!