Removing color restrictions and adding tests

tomron commented 7 months ago

Remove restriction to tag color and therefore able to use any color representation enabled by HTML (hexa, RGB, names, etc). The value of those strings is not validated.

Relates to - https://github.com/arnaudmiribel/streamlit-extras/issues/207

netlify[bot] commented 7 months ago

Deploy Preview for phenomenal-crepe-0effec ready!

Name	Link
Latest commit	2d777b65de9dd071c0a69b3639190a62ee79cc63
Latest deploy log	https://app.netlify.com/sites/phenomenal-crepe-0effec/deploys/659ef7238e2f2400085a37a6
Deploy Preview	https://deploy-preview-208--phenomenal-crepe-0effec.netlify.app
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

arnaudmiribel commented 6 months ago

Hey @tomron, sorry for the delay! Thanks for submitting a PR. Few questions:

Can you set up pre-commit properly? Looks like linting is broken! You can just run pip install pre-commit && pre-commit install in your repo, and then any commit you do will require the linting checks to pass.
I think you want to update the function docstring here to allow for custom color codes
Can you add support for custom colors, while keeping the current support of the TAGGER_COLOR_PALETTE? The palette we hardcoded there suits the streamlit stylesheet much better than default CSS properties. Also, if we don't do that, apps upgrading will have their colors unexpectedly change! Probably just boils down to:

# If exists in our palette, then use the hardcoded color code, else pass as CSS literal
background-color: {TAGGER_COLOR_PALETTE.get(color, color)};

Thanks!

tomron commented 6 months ago

Hi @arnaudmiribel ,

Fixed both issues

arnaudmiribel / streamlit-extras