arnaudmiribel / streamlit-extras

Discover, try, install and share Streamlit re-usable bits we call "extras"!
https://extras.streamlit.app
Apache License 2.0
727 stars 124 forks source link

support for text_color in tags #248

Closed alon-sht closed 1 week ago

netlify[bot] commented 2 weeks ago

Deploy Preview for phenomenal-crepe-0effec ready!

Name Link
Latest commit 200c4fc3926a050f30204e7d25fddd990827678e
Latest deploy log https://app.netlify.com/sites/phenomenal-crepe-0effec/deploys/66d5b2c874a2670008cb2ba5
Deploy Preview https://deploy-preview-248--phenomenal-crepe-0effec.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

arnaudmiribel commented 2 weeks ago

Hey @alon-sht, thanks for the PR. I'm working on fixing the CI failing in https://github.com/arnaudmiribel/streamlit-extras/pull/250

arnaudmiribel commented 2 weeks ago

@alon-sht please pull from main after https://github.com/arnaudmiribel/streamlit-extras/pull/250 was merged - this should solve the deploy issue

alon-sht commented 2 weeks ago

Please take a look now :)

arnaudmiribel commented 2 weeks ago

@alon-sht would you mind making sure the linting is right? We use pre-commit, hopefully you're familiar with that.

tl;dr:

pip install pre-commit
pre-commit install
pre-commit run --all
alon-sht commented 2 weeks ago

It's new to me I've ran pre-commit and fixed a bug

arnaudmiribel commented 2 weeks ago

Well done fixing the linting issues with pre-commit. Looks like there are still errors running the test: see here

By the way, wanted to call out Streamlit now has nice native way to make tags if you're interested - see colored text in docs.

image
alon-sht commented 2 weeks ago

I tried adding another fix I'm currently having trouble running pytest in my IDE for some reason.

alon-sht commented 2 weeks ago

Streamlit's native way is nice, but your implementation is prettier and more versatile in terms of color options :)

alon-sht commented 1 week ago

Latest commit passed all tests