search

arnaudon / netSALT

Simulation of lasing networks with quantum graphs and SALT theory.
https://arnaudon.github.io/netSALT/
GNU General Public License v3.0
5 stars 1 forks source link

Laplacian quality using determinant #18

Closed razimantv closed 2 years ago

razimantv commented 2 years ago

Added determinant-based laplacian quality. Currently finding determinant by turning the matrix dense. It is also possible to do it with LU decomposition, but that seems slow for the smaller matrices I tried.

TODO: Add Luigi config to select quality determination method

arnaudon commented 2 years ago

thanks, I'll add this option in luigi and merge asap

arnaudon commented 2 years ago

@razimantv , try this update with quality_method=determinant in section [ModeSearchConfig] to see if it works!

razimantv commented 2 years ago

Finds passive modes but only if I call find_rough_modes_from_scan with a reduced threshold_abs of 0.01 and set quality_threshold in the config to 1.

arnaudon commented 2 years ago

ah yes, these values are wrt to quality value, which changes if you compute eig or svd, or det. So this PR works for you, I can merge?

razimantv commented 2 years ago

Perhaps after another (!) config parameter for threshold_abs?

arnaudon commented 2 years ago

ah sorry, I didn't realise this is not in luigi, ok I'll add it

arnaudon commented 2 years ago

here you are, I added also min_distance, just in case!