arnaudroger / SimpleFlatMapper

Fast and Easy mapping from database and csv to POJO. A java micro ORM, lightweight alternative to iBatis and Hibernate. Fast Csv Parser and Csv Mapper
http://simpleflatmapper.org
MIT License
437 stars 76 forks source link

Enable builder extends #583

Closed zenios closed 5 years ago

zenios commented 5 years ago

Builder pattern with asm does not pickup methods from parent class

zenios commented 5 years ago

Great.

When can we expect a release?

I am using SFM with JOOQ and Builder extends pattern and without this fix i have to implement many workarounds.

arnaudroger commented 5 years ago

I'll do that today, trying to see if I can put a few other fixes with it

On Tue, Nov 13, 2018 at 11:51 AM zenios notifications@github.com wrote:

Great.

When can we expect a release?

I am using SFM with JOOQ and Builder extends pattern and without this fix i have to implement many workarounds.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/arnaudroger/SimpleFlatMapper/pull/583#issuecomment-438239577, or mute the thread https://github.com/notifications/unsubscribe-auth/AF4ErfT-hjugnnQr6-dREFZFNKqEWJr0ks5uurJdgaJpZM4YbeHu .

zenios commented 5 years ago

Looks like my changes broke sfm-test-proto

On Tue, Nov 13, 2018 at 1:58 PM Arnaud Roger notifications@github.com wrote:

I'll do that today, trying to see if I can put a few other fixes with it

On Tue, Nov 13, 2018 at 11:51 AM zenios notifications@github.com wrote:

Great.

When can we expect a release?

I am using SFM with JOOQ and Builder extends pattern and without this fix i have to implement many workarounds.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub < https://github.com/arnaudroger/SimpleFlatMapper/pull/583#issuecomment-438239577 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AF4ErfT-hjugnnQr6-dREFZFNKqEWJr0ks5uurJdgaJpZM4YbeHu

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/arnaudroger/SimpleFlatMapper/pull/583#issuecomment-438241154, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFd4XPG1SttzVqpv8TeJr-JGajwlVDiks5uurPYgaJpZM4YbeHu .

arnaudroger commented 5 years ago

yes just fixed it, new method became visible, just added something to ignore them protobuf methods are a mess

On Tue, Nov 13, 2018 at 11:59 AM zenios notifications@github.com wrote:

Looks like my changes broke sfm-test-proto

On Tue, Nov 13, 2018 at 1:58 PM Arnaud Roger notifications@github.com wrote:

I'll do that today, trying to see if I can put a few other fixes with it

On Tue, Nov 13, 2018 at 11:51 AM zenios notifications@github.com wrote:

Great.

When can we expect a release?

I am using SFM with JOOQ and Builder extends pattern and without this fix i have to implement many workarounds.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <

https://github.com/arnaudroger/SimpleFlatMapper/pull/583#issuecomment-438239577

, or mute the thread <

https://github.com/notifications/unsubscribe-auth/AF4ErfT-hjugnnQr6-dREFZFNKqEWJr0ks5uurJdgaJpZM4YbeHu

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub < https://github.com/arnaudroger/SimpleFlatMapper/pull/583#issuecomment-438241154 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AAFd4XPG1SttzVqpv8TeJr-JGajwlVDiks5uurPYgaJpZM4YbeHu

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/arnaudroger/SimpleFlatMapper/pull/583#issuecomment-438241513, or mute the thread https://github.com/notifications/unsubscribe-auth/AF4ErSr9jsWKJDTfvBdhEu7ipDk7s7HRks5uurQsgaJpZM4YbeHu .

zenios commented 5 years ago

I was looking at it right now.I don't like how proto methods get excluded by hand but i am not sure whether there is any alternative

On Tue, Nov 13, 2018 at 2:29 PM Arnaud Roger notifications@github.com wrote:

yes just fixed it, new method became visible, just added something to ignore them protobuf methods are a mess

On Tue, Nov 13, 2018 at 11:59 AM zenios notifications@github.com wrote:

Looks like my changes broke sfm-test-proto

On Tue, Nov 13, 2018 at 1:58 PM Arnaud Roger notifications@github.com wrote:

I'll do that today, trying to see if I can put a few other fixes with it

On Tue, Nov 13, 2018 at 11:51 AM zenios notifications@github.com wrote:

Great.

When can we expect a release?

I am using SFM with JOOQ and Builder extends pattern and without this fix i have to implement many workarounds.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <

https://github.com/arnaudroger/SimpleFlatMapper/pull/583#issuecomment-438239577

, or mute the thread <

https://github.com/notifications/unsubscribe-auth/AF4ErfT-hjugnnQr6-dREFZFNKqEWJr0ks5uurJdgaJpZM4YbeHu

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <

https://github.com/arnaudroger/SimpleFlatMapper/pull/583#issuecomment-438241154

, or mute the thread <

https://github.com/notifications/unsubscribe-auth/AAFd4XPG1SttzVqpv8TeJr-JGajwlVDiks5uurPYgaJpZM4YbeHu

.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub < https://github.com/arnaudroger/SimpleFlatMapper/pull/583#issuecomment-438241513 , or mute the thread < https://github.com/notifications/unsubscribe-auth/AF4ErSr9jsWKJDTfvBdhEu7ipDk7s7HRks5uurQsgaJpZM4YbeHu

.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/arnaudroger/SimpleFlatMapper/pull/583#issuecomment-438249229, or mute the thread https://github.com/notifications/unsubscribe-auth/AAFd4fxxAFQlnGzRCGO7eHWRt4CdCLDEks5uurs9gaJpZM4YbeHu .

arnaudroger commented 5 years ago

I don't like it either :) but it works there.

arnaudroger commented 5 years ago

6.0.8 is now available in maven central with change