search

arnaudroger / SimpleFlatMapper

Fast and Easy mapping from database and csv to POJO. A java micro ORM, lightweight alternative to iBatis and Hibernate. Fast Csv Parser and Csv Mapper
http://simpleflatmapper.org
MIT License
440 stars 76 forks source link

add DSLContextProvider to decouple Jooq configuration #694

Closed hank-cp closed 5 years ago

hank-cp commented 5 years ago

JooqMapperFactory.newRecordUnmapperProvider() requires a org.jooq.Configuration, in the meantime RecordUnmapperProvider is also a setting for org.jooq.Configuration. This will cause cycle dependencies when creating org.jooq.Configuration instance. This DSLContextProvider could be introduced to decouple both.

coveralls commented 5 years ago

Coverage Status

Coverage remained the same at 84.908% when pulling 5d378fc286a8b5a99a73cf382c0737d7c43c5d1a on hank-cp:master into e23f19a6cbc47320c0767c835dd197c6b8bd1f4d on arnaudroger:master.

arnaudroger commented 5 years ago

will try to get another couple of little thing with next release, ETA a couple of days. will see if I can get Lukas to change the provider so that it passes the configuration as part of the provides method that would eliminate the need for that.

arnaudroger commented 5 years ago

that's released in 8.2.1 @hank-cp