arnaudroger / SimpleFlatMapper

Fast and Easy mapping from database and csv to POJO. A java micro ORM, lightweight alternative to iBatis and Hibernate. Fast Csv Parser and Csv Mapper
http://simpleflatmapper.org
MIT License
435 stars 76 forks source link

Unordered join not working #756

Open danboch opened 3 years ago

danboch commented 3 years ago

Hi, we have a mapper defined like this:

JdbcMapperFactory.newInstance() .useAsm(false) .addKeys(ID, alias(OTHER_ID)) .unorderedJoin() .assumeInjectionModifiesValues(true) .newMapper(Some.class))

Although unorderedJoin is set, it does not work. When I debugged it turns out that in SetRowMapperBuilderImpl in mapper() method it returns the mapper created in line 117 (newJoinMapper). Shouldn't it return a newUnorderedJoinMapper like in line 130? Or am I missing something?

danboch commented 3 years ago

It seems that assumeInjectionModifiesValues(true) causes unOnordered join to be ignored.