search

arnaudsm / raito

Mini Markdown Wiki/CMS in 8kb of JavaScript
https://raito.arnaud.at
MIT License
107 stars 13 forks source link

IDea: footer support like was with components #48

Closed mckaygerhard closed 11 months ago

mckaygerhard commented 11 months ago

as same components did with navbar i noted same can be done with few lines with footer, thsi commit does not include the footer.md file

arnaudsm commented 11 months ago

Great addition thank you ! Would you mind adding an example docs/footer.md since you added it to the config ?

mckaygerhard commented 11 months ago

yeah i can add in this PR the example , just gime me some hours that i have to deal with some home task XD @arnaudsm

mckaygerhard commented 11 months ago

Great addition thank you ! Would you mind adding an example docs/footer.md since you added it to the config ?

Done with commit 280b46452a11748e48a879311cb1c534c3c45157 @arnaudsm i hope i do it in right way cos i made it using the phone (was so uncomfortable )

arnaudsm commented 11 months ago

One last thing, the feature broke the Subdirectory test.

Replace getByText("b") by getByText("b", { exact: true }) in main.test.js

You can run the tests with

cd tests
yarn
npx playwright install chromium
yarn test # or `yarn debug` for interactive view
mckaygerhard commented 11 months ago

Thanks, that feature is a great addition 👍 You can merge it

err .. men! i m just a collaborator XD XD XD i cannot merge it XD