Subdir support

[uli-heller]

I forked raito and added subdir support to it (among others). Now I realized that there is a TODO list at the end of the README.md and "subdir support" shows up there.

Are you interested in a pull request?

Currently, my fork is probably way to fat but I'd factor out the subdir support in case you're interested.

Here, there are some examples of some nested subdirs to illustrate my understanding of the feature:

issues.zip subfolder-01.zip

[arnaudsm]

I'm sorry but subdir support was already implemented, but not documented. That's why it was checked in the todolist.. However there's great additions in your fork, thank you for your work!

Which new features would you like to merge ? I'd love to do a PR

[uli-heller]

Hey Arnaud,

I've setup an instance of my fork of RAITO containing subfolders with relative links. I'm going to add these subfolders to a pull request. I guess these subfolders do work on my fork but not on the original raito.

See https://uli-heller.github.io/raito/index.html#/subfolder-01/README.md for the subfolders.

Are you going to support these kind of subfolders?

Thx, Uli

[arnaudsm]

Subfolders with relative links already work in the original raito. Sorry for the misunderstanding, I just added documentation about it. I also made an working example for you : https://github.com/arnaudsm/raito/tree/subdir-example

Is there any other feature you'd like to merge ?

[uli-heller]

... this is how it looks for me. Clicking on the link gives me this:

Does not look OK to me!

[arnaudsm]

This is not a bug, all markdown links should be relative (no starting /), and root directories should end with /. Here's a working example

Since this was unclear, I'm adding more clarifications in the documentation.

[uli-heller]

Ok, so you cannot use relative links within subfolders. I think this is quite bit unfortunate. But that's my personal opinion. Thx for taking the time looking at this. -- Diese Nachricht wurde von meinem Android-Gerät mit K-9 Mail gesendet.

Am 23. Januar 2022 07:12:05 MEZ schrieb Arnaud de Saint Meloir @.***>:

This is not a bug, all markdown links should be absolute (no starting /), and root directories should end with /. Here's a working example

Since this was unclear, I'm adding more clarifications in the documentation.

-- Reply to this email directly or view it on GitHub: https://github.com/arnaudsm/raito/issues/9#issuecomment-1019423125 You are receiving this because you authored the thread.

Message ID: @.***>

[arnaudsm]

Sorry for the typo, I meant relative. Take a look at the example I made for you, it works perfectly!

[uli-heller]

Your example uses relative paths but treats them as absolute paths, doesn't it? See https://stackoverflow.com/questions/24028561/relative-path-in-html for some details