arnav-kr / json-formatter

A Browser Extension to format JSON in the browser automatically. Available with 60+ Themes, Syntax Highlighting, automatically linkifies links and more.
https://json-formatter.js.org
MIT License
71 stars 13 forks source link

Bug: Chrome native UI preventing JSON Formatter #17

Closed tippold closed 11 months ago

tippold commented 11 months ago

Is there an existing issue for this?

Describe the bug

Chrome seems to have introduced a new feature called "pretty print" when opening JSON files. It seems that this is blocking the JSON formatter from working properly. The usual UI elements and formatting are not displayed.

Using Chrome version 117.0.5938.62

Your extension is the most convenient JSON formatter out there, so a fix would be very much appreciated. Thank you!

Expected Behavior

JSON Files in browser are formatted and extension UI is displayed.

Steps To Reproduce

  1. Open JSON feed in browser
  2. Top of page shows Chrome pretty print option
  3. JSON is not formatted and extension not displayed in browser window

System Info

- OS: Mac OSX Ventura 13.5.2 (22G91)
- Browser: Version 117.0.5938.62

Additional context?

jsonfeed

arnav-kr commented 11 months ago

Fixed By https://github.com/arnav-kr/json-formatter/commit/afc7c7fb2f5bb7922fd12cfbf012e3c3f4643d84

I have submitted it for review, would take a bit time to be published on the Webstore due to review process,

I'll notify you here once its live on webstore,

Once updated you'd see this popup when you open a json file to confirm

image

By the way, Thanks for Notifying Early ✨, its been a week since chrome 117 released and the uninstalls already increased due to this issue, i wonder how bad it would have been if it was left unnoticed for more time.

tippold commented 11 months ago

You're welcome! Thank you for reacting so quickly and for all of your continued efforts. Keep up the great work 😃

arnav-kr commented 11 months ago

@tippold The Extension is live on the webstore: https://jsonformatter.page.link/chrome

image

chrome should auto update it Btw that popup won't be visible, as i forgot to reset it, you can check the version on extension page chrome://extensions/?id=gpmodmeblccallcadopbcoeoejepgpnb