arnavb / pypokedex

A minimal pokedex library for Python
MIT License
29 stars 3 forks source link

Add instance variables for other sprites in the sprite key #18

Closed arnavb closed 4 years ago

arnavb commented 4 years ago

Fixes #17

Since adding support for new sprites shouldn't change how sprites are regularly dealt with, this change should be backwards compatible. Once merged, this will be released as v1.5.0.

TODO:

codecov[bot] commented 4 years ago

Codecov Report

Merging #18 into master will decrease coverage by 5.47%. The diff coverage is 70.37%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #18      +/-   ##
===========================================
- Coverage   100.00%   94.52%   -5.48%     
===========================================
  Files            4        4              
  Lines          126      146      +20     
  Branches        20       26       +6     
===========================================
+ Hits           126      138      +12     
- Misses           0        6       +6     
- Partials         0        2       +2     
Impacted Files Coverage Δ
pypokedex/api.py 100.00% <ø> (ø)
pypokedex/pokemon.py 92.59% <70.37%> (-7.41%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1fe4b53...201d6bf. Read the comment docs.