search

arnemolland / sigv4

Dart library for signing AWS requests with Signature Version 4
MIT License
17 stars 23 forks source link

Correct failing tests after switching to null-safety #31

Closed pflugs30 closed 3 years ago

pflugs30 commented 3 years ago

Thanks for creating this package. I just updated my project to null safety today, and I started getting the same error #26. I noticed the recent PR #29 fixed this issue, but the Action to deploy the package failed. Since I cannot use the null safe version of this package until the corrected version is deployed, I created this pull request.

Switching Mockito to use generated stubs. Modifying one client_test method to generate an actual class, not a stub. Modifying CI workflow to analyze only library code since there will now be missing references in the client_test.dart file.

pflugs30 commented 3 years ago

Hi Arne,

Thanks for merging the PR. I see the package didn't push to Pub.dev, and I'm confident it's because I didn't change the version number for the null-safety branch.

Would you please bump the version number for the null-safwty branch so the package pushes? I'd appreciate it very much.

Thanks, Matthew

On Thu, Apr 29, 2021, 11:32 PM Arne Molland @.***> wrote:

Merged #31 https://github.com/arnemolland/sigv4/pull/31 into null-safety.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/arnemolland/sigv4/pull/31#event-4666865303, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABBUPOHFPX5A775WMZF776LTLIXFPANCNFSM43TXTDWA .

arnemolland commented 3 years ago

Thanks for the contribution @pflugs30! I'll look into it asap when I have a computer in my hands.