search

arnemolland / sigv4

Dart library for signing AWS requests with Signature Version 4
MIT License
17 stars 23 forks source link

Change to Github action YAML to build and deploy prerelease branch #34

Closed pflugs30 closed 3 years ago

pflugs30 commented 3 years ago

I realized after PR #33 was merged that it didn't deploy to pub dev because the deploy steps of the workflow have a condition to only run on the master branch. Since we want the prerelease branch of null-safety to also deploy, I removed the conditions on the workflow steps and added a condition to the on trigger for the workflow. now the action will run on either the master or the null-safety branch.

The consequence of this decision is that the workflow would not run for any feature branch. However, since this repository isn't highly active, I don't think that will be an issue. Ideally, we'd split the workflow script into two files: one for build and test (which runs for all branches), and one for deploy (which only runs for specific branches).

Thanks for your continued review, @arnemolland.

arnemolland commented 3 years ago

Thanks for the contribution!

pflugs30 commented 3 years ago

Thank you for sticking with me through these several changes! Much appreciated.