arnesson / cordova-plugin-firebase

Cordova plugin for Google Firebase
http://arnesson.github.io/cordova-plugin-firebase
MIT License
1.01k stars 1.55k forks source link

Add ML Kit support #685

Open rathodkaran07 opened 6 years ago

rathodkaran07 commented 6 years ago

Yesterday at Google I/O a new feature was announced for Firebase: ML Kit. Can we have that support for this plugin?

sangeetjass commented 6 years ago

That would be really awesome, if someone can enable these for cordova...

cissemy commented 6 years ago

That will be Great.

badesemowo commented 6 years ago

It will be great to have ML Kit easily integrated with Cordova App. My team is experimenting with it.

ghost commented 6 years ago

I'm not criticizing Google, but...firebase had a bad reputation in my eye with the fms related stuff, so i just created my own solution. I have used mobile vision api before, now it's a set back to rewrite everything, and the CameraSource class hasn't been even implemented, just i have seen in the quickstart-android samples, so it's tons of code, what i need to refactor from Google to make it usable. It's not fun anymore.

I think i'm just not using any barcode scanning. Google Maps Api in july 16 needs card activation even if you are using the free features only. So i think relying on Google products, whatever it's i'm not sure that it worth, as it kept changing. You just create a cordova plugin, and next day Google just wind down the api completely.

At the moment i'm working on some sort of social library, but i think capacitor is way better than cordova, even in beta. At the moment you cannot build an android plugin, but it works in the main code, so when they finish you can move to plugin whatever you have done.

I just finished an mqtt integration,very likely i make a google map, a face / barcode detector. (both of them are using overlay with click bait technic, so i just separate this code to be able to reuse for other native stuff, which has native ui also and needs to calculate whether native or webview component has been touched)

The google map also kept changing, so every month you need to refactor the cordova google maps. That's the only plugin which has been maintained very well.

Capacitor is mostly a syntactic sugar over the Cordova, but it matters a lot how to write your plugin. It seems you can build ios plugin already.

rg777 commented 5 years ago

Are there any updates to this request? @badesemowo was your team able to create cordova plugin for ML Kit?

paulstelzer commented 5 years ago

I think ML Kit should be a seperate plugin because not everyone who uses Firebase wants to use ML Kit, too. So I made a startingpoint for ML Kit -> https://github.com/paulstelzer/cordova-plugin-ml-kit

Everyone is invited to make Pull Requests because at the moment I only implemented Text recognition :)

soumak77 commented 5 years ago

Thanks @paulstelzer! One suggestion that I have is to include the word firebase in the plugin name.

RicardoElSabio commented 4 years ago

@paulstelzer I tried the plugin you created it doesnt seem to work, and i see that you havent been maintaining it correct? when im logging this in app component: console.log('ML KIT', window['MlKitPlugin']); The result is : ML KIT undefined