search

arnested / drupal-mode

Advanced Emacs minor mode for Drupal development
https://melpa.org/#/drupal-mode
GNU General Public License v3.0
32 stars 14 forks source link

Cope with different implementations of flymake-phpcs. #40

Closed arnested closed 10 years ago

arnested commented 10 years ago

There now exists two different implementations of a flymake-phpcs.el:

Drupal-mode has supported @illusori's version for quite some time and unfortunately @senda-akiha's version needs to be invoked in a different way and variables are named differently.

The problem gets worse because @illusori's version has been in Marmalade for a long time and now @senda-akiha's version has been added to MELPA. Users will now risk being "upgraded" to @senda-akiha's version without noticing - and things will break.

I'll try to support both versions.

arnested commented 10 years ago

With @senda-akiha's merge of senda-akiha/flymake-phpcs#1, senda-akiha/flymake-phpcs#2, and senda-akiha/flymake-phpcs#3 I have incorporate support for both implementations of flymake-phpcs in commit a25b4df69a8c23920cada4392901ff07ae6e7d21.