arnested / drupal-mode

Advanced Emacs minor mode for Drupal development
https://melpa.org/#/drupal-mode
GNU General Public License v3.0
32 stars 14 forks source link

Flycheck errors with drupal-mode #55

Closed kostajh closed 9 years ago

kostajh commented 9 years ago

Something odd has happened in the last few days, hard to pin down exactly when it started - but there have been updates to php mode, drupal-mode, and flycheck mode.

First of all, if I open a Drupal 6 file example.module, Drupal mode isn't set. If I do M-x drupal-mode I get this error:

Debugger entered--Lisp error: (void-function flycheck-set-checker-properties)
  flycheck-set-checker-properties(drupal-phpcs ((flycheck-documentation . "Check non-PHP Drupal files using PHP_CodeSniffer.\n\nThe Drupal standard includes checks for non-PHP files, this\nchecker runs those.\n\nSee URL `http://pear.php.net/package/PHP_CodeSniffer/'.") (flycheck-executable-var . flycheck-drupal-phpcs-executable) (flycheck-command "phpcs" "--report=emacs" (option "--standard=" flycheck-phpcs-standard concat) source-inplace) (flycheck-error-parser . flycheck-parse-with-patterns) (flycheck-error-patterns ("^\\(?1:.+?\\):\\(?2:[[:digit:]]+\\):\\(?3:[[:digit:]]+\\): error - \\(?4:.+\\)$" . error) ("^\\(?1:.+?\\):\\(?2:[[:digit:]]+\\):\\(?3:[[:digit:]]+\\): warning - \\(?4:.+\\)$" . warning)) (flycheck-error-filter . flycheck-sanitize-errors) (flycheck-modes) (flycheck-predicate . #[nil "\303\304\305 \n#\"\207" [drupal-css-modes drupal-js-modes drupal-info-modes apply derived-mode-p append] 6]) (flycheck-next-checkers) (flycheck-file . "/home/kosta/.emacs.d/elpa/drupal-mode-20141116.515/drupal/flycheck.el")))
  byte-code("\306\307\310\"\210\311\312\313\314\315\316\317\320\321\322&    \210\323\312!\210\324\325\326\327\330\331\332B\333\334\335B\336\337\340B\341\342\343 B\257\n\"\210\344\345\325\322#\210\346    \n#\347 \313\211\203p

If I open index.php in the docroot of a Drupal 7 site, Drupal mode is set, but I get this error:

Debugger entered--Lisp error: (void-function flycheck-set-checker-properties)
  flycheck-set-checker-properties(drupal-phpcs ((flycheck-documentation . "Check non-PHP Drupal files using PHP_CodeSniffer.\n\nThe Drupal standard includes checks for non-PHP files, this\nchecker runs those.\n\nSee URL `http://pear.php.net/package/PHP_CodeSniffer/'.") (flycheck-executable-var . flycheck-drupal-phpcs-executable) (flycheck-command "phpcs" "--report=emacs" (option "--standard=" flycheck-phpcs-standard concat) source-inplace) (flycheck-error-parser . flycheck-parse-with-patterns) (flycheck-error-patterns ("^\\(?1:.+?\\):\\(?2:[[:digit:]]+\\):\\(?3:[[:digit:]]+\\): error - \\(?4:.+\\)$" . error) ("^\\(?1:.+?\\):\\(?2:[[:digit:]]+\\):\\(?3:[[:digit:]]+\\): warning - \\(?4:.+\\)$" . warning)) (flycheck-error-filter . flycheck-sanitize-errors) (flycheck-modes) (flycheck-predicate . #[nil "\303\304\305 \n#\"\207" [drupal-css-modes drupal-js-modes drupal-info-modes apply derived-mode-p append] 6]) (flycheck-next-checkers) (flycheck-file . "/home/kosta/.emacs.d/elpa/drupal-mode-20141116.515/drupal/flycheck.el")))
  byte-code("\306\307\310\"\210\311\312\313\314\315\316\317\320\321\322&    \210\323\312!\210\324\325\326\327\330\331\332B\333\334\335B\336\337\340B\341\342\343 B\257\n\"\210\344\345\325\322#\210\346    \n#\347 \313\211\203p

Any ideas?

arnested commented 9 years ago

@xendk?

kostajh commented 9 years ago

@arnested and @xendk, I wonder if something changed with flycheck's API - I also got similar errors with flycheck-ledger, and had to disable that package. I'm on IRC as kostajh if I can help answer any questions you have.

xendk commented 9 years ago

Try recompiling/reinstalling flycheck/dash/drupal-mode. Seems to be the fix to a lot of similar issues. There's certainly no flycheck-set-checker-properties in current versions of flycheck, so maybe start with recompiling drupal-mode.

Drupal mode not being set, that's for you @arnested .

kostajh commented 9 years ago

Recompiling those modes fixed both the flycheck issues and Drupal mode not being set. Thanks for your help!

Thomas Fini Hansen writes:

Try recompiling/reinstalling flycheck/dash/drupal-mode. Seems to be the fix to a lot of similar issues. There's certainly no flycheck-set-checker-properties in current versions of flycheck, so maybe start with recompiling drupal-mode.

Drupal mode not being set, that's for you @arnested .


Reply to this email directly or view it on GitHub: https://github.com/arnested/drupal-mode/issues/55#issuecomment-65755343

kostaharlan.net | @kostajh