search

arnested / drupal-spell

Aspell extra dictionary for Drupal / Emacs
GNU General Public License v3.0
4 stars 2 forks source link

Mention availability of MELPA packages #1

Closed purcell closed 11 years ago

purcell commented 11 years ago

I've just added a MELPA recipe for this package, so here's a corresponding update to the README. :-)

-Steve

arnested commented 11 years ago

Actually the MELPA package won't work out of the box.

The dict/drupal.aspell file (the actual dictionary in aspell format) is needed but not included in my repository. It is build from the dict/drupal.txt file (see the Makefile).

So users of MELPA will have to build the file manually (and know how to do it).

arnested commented 11 years ago

I will gladly mention the MELPA version in the README but think we/I should figure out how to build the dict/drupal.aspell file when installing the package.

purcell commented 11 years ago

Ah! Doh! Oops!

MELPA will never be able to generate the file, since we don't run any non-Emacs processes on the build server as a matter of policy, but perhaps it's possible to automatically generate it when the library is loaded... it appears from your Makefile that the aspell executable is all that is required.

I guess I should maybe remove the recipe in the meantime. :-/

-Steve

arnested commented 11 years ago

:smile:

Yes, I was thinking about triggering it from within Emacs if dict/drupal.aspell is not present but dict/drupal.txt is.

I think removing it from MELPA until that is resolved would be a good idea (no need to push useless stuff on people).

arnested commented 11 years ago

Hey @purcell.

I added an attempt at generating the dictionary if it is not present. I think this will work for MELPA.

Could you test it / verify if it works for you as well?

If so I will do a new release / push it to the master branch.

purcell commented 11 years ago

I think that's pretty close to working. The defcustom fails for me, because it needs to come after the drupal-spell-find-dictionary function. If you reverse the order of those 2, everything works beautifully.

purcell commented 11 years ago

Awesome. I've re-added the MELPA recipe. :-)

arnested commented 11 years ago

Cool. Thanks.