arnested / php-extras

Extra features for Emacs `php-mode'.
GNU General Public License v3.0
32 stars 6 forks source link

Fix function argument annotations in company-mode #12

Closed joddie closed 10 years ago

joddie commented 10 years ago

This fixes a dumb mistake in my original patch to add company-mode support. The original patch put the whole string including return type and function name inside the parentheses. I knew that the function argument strings seemed awfully long but I couldn't figure out why .. duh.

This one strips off everything before the first open-paren when using the string as a company-mode annotation.

dgutov commented 10 years ago

This is better indeed. :) You also might want to rename the local var: arguments -> prototype.

joddie commented 10 years ago

Good point, thanks.