arnested / php-extras

Extra features for Emacs `php-mode'.
GNU General Public License v3.0
32 stars 6 forks source link

Problems enabling ELDoc mode. #16

Closed aaronbieber closed 3 years ago

aaronbieber commented 8 years ago

I left a comment in a different issue thread about this, but I think it's an actual issue so I'm opening it as a separate one here. The first snag that I hit was that php-extras could not define "eldoc-documentation-function" properly because in my configuration it was set to "ignore," which fails the "unless" case in php-extras.el:124.

According to the eldoc documentation, rather than (set (make-local-variable ...)), major modes should do something like:

(add-function :before-until (local 'eldoc-documentation-function)
              #'php-extras-eldoc-documentation-function)

I ran that code and it seemed to configure the function correctly.

The next problem I ran into is that whenever I place point on a PHP function name, I simply get "parse error" in the minibuffer.

aaronbieber commented 8 years ago

I figured out the "parse error" situation; flycheck is overwriting the eldoc output in the minibuffer, which is annoying, but I'll find some way around that. I quite often want to see eldoc information while in the middle of editing and at that moment the file is not syntactically correct (obviously).

The method of configuring the eldoc documentation function still seems to be sub-optimal, though. I'll continue my experimentation.