search

arnested / php-extras

Extra features for Emacs `php-mode'.
GNU General Public License v3.0
32 stars 6 forks source link

Merge With php-mode #2

Open ejmr opened 11 years ago

ejmr commented 11 years ago

Hello @arnested,

I am the current maintainer of php-mode. I want to support Eldoc mode in the next version of php-mode and have been discussing different approaches. Since you already implemented functionality for Eldoc mode in php-extras I wanted to ask if you would be ok with your work put into php-mode itself.

And not just the Eldoc-related code. I like all of the functionality that php-extras provides and would be happy to have it as part of php-mode, with your permission.

arnested commented 11 years ago

@dhaley made me aware of the discussion over at ejmr/php-mode#70. I just hadn't had the time to look into it yet.

I would be happy to let php-extras be merged into php-mode. It has more or less been a test bed for experimental features. The right place for it is of course php-mode itself.

Beware that the php-extras-generate-eldoc-1 function might be a bit fragile. At least I'm sure there must be a cleaner way to extract the function arguments from the manual (now it search for a known location and the runs libxml-parse-html-region on a region from there).

Also have you given a thought about distributing a prebuilt hash table of functions and their arguments? I do that in the ELPA-package at Marmalade.

Generating the hash table can take some time and requires an Emacs build with libxml2. So it makes sense to make it easier for ordinary users to benefit from this by distribution a prebuilt table. On the other hand that puts the burden of regenerating the table when the PHP documentation is updated on the maintainers (no, I haven't setup some kind of notification yet when the documentation is updated).

arnested commented 10 years ago

Just for the record after the merge of #9 an Emacs build with libxml2 is no longer a requirement for building the hash table.

jhenahan commented 9 years ago

@ejmr @arnested Any further developments on this? A merge would handily deal with syl20bnr/spacemacs#1314, as well. :smile:

ejmr commented 9 years ago

@jhenahan Unfortunately there hasn't been any further development. PHP Mode, along with many other things, got pushed aside the past couple of months for personal reasons---I was barely on the Internet for the entirety of May in fact. In early March I started testing out a merge locally, seeing what I might have to tweak here and there to get things working, but then that grinded to a halt.

I will make it a priority to try and merge in php-extras by the end of the month.

aaronbieber commented 8 years ago

This is slightly off-topic, but I have built eldoc sources with php-extras-generate-eldoc and when activating ELDoc mode I still get "There is no ELDoc support in this buffer." Is there something else I have to do that isn't mentioned in the README?

Happy to help expand documentation, etc., as well. I use PHP daily and rely pretty heavily on php-mode and php-extras.

ejmr commented 8 years ago

@aaronbieber Not that I know of but @arnested would probably be able to answer that better than me.

mateusfccp commented 6 years ago

I'm having the same problem as @aaronbieber, although it passes more than 2 years.