search

arnested / php-extras

Extra features for Emacs `php-mode'.
GNU General Public License v3.0
32 stars 6 forks source link

Make eldoc documentation work when point is in a function argument list. #5

Closed joddie closed 11 years ago

joddie commented 11 years ago

Hi! Thanks for php-extras. I've been using it for work coding after being away from PHP for a while and it's making things much more pleasant.

This patch is a simple hack which improves the Eldoc support (IMO) by continuing to show the argument hints when point is within a function argument list. It works very simply: if the first call to `(gethash ...)' returns nil, then Emacs tries to go up one level of parens (when possible) and look up whatever symbol it finds there instead.

It might not be too hard to get it to highlight the current argument as well, but I've been too lazy to work that out so far ;-)

arnested commented 11 years ago

Nice. Merged into develop branch.