arnetheduck / nph

An opinionated code formatter for Nim
Other
77 stars 12 forks source link

Doesn't build against nim master branch #66

Closed kraptor closed 3 months ago

kraptor commented 3 months ago

The following error is thrown, if trying to build against Nim master:

Downloading https://github.com/arnetheduck/nph using git
  Verifying dependencies for nph@0.5.1
 Installing nph@0.5.1
   Building nph/nph using c backend
/tmp/nimble_27726/githubcom_arnetheducknph/src/astyaml.nim(137, 17) Error: undeclared field: 'sons' for type ast.PType [type declared in /home/kraptor/.choosenim/toolchains/nim-#devel/compiler/ast.nim(789, 3)]
Downloading https://github.com/arnetheduck/nph using git
  Verifying dependencies for nph@0.5.1
 Installing nph@0.5.1
   Building nph/nph using c backend
/tmp/nimble_27726/githubcom_arnetheducknph_#head/src/astyaml.nim(137, 17) Error: undeclared field: 'sons' for type ast.PType [type declared in /home/kraptor/.choosenim/toolchains/nim-#devel/compiler/ast.nim(789, 3)]
       Tip: 8 messages have been suppressed, use --verbose to show them.
nimble.nim(235)          buildFromDir

    Error:  Build failed for the package: nph

Probably due to: https://github.com/nim-lang/Nim/commit/469c9cfab487380ba85520c90a2fad7d658c3023

arnetheduck commented 3 months ago

nph does generally not support nim devel - if you have a patch that works for both the supported 2.0.2 version and devel, it is welcome, but there's no plan to follow devel as of now