search

arnetheduck / nph

An opinionated code formatter for Nim
Other
77 stars 12 forks source link

x32 and x64 binaries for windows are both x64. #8

Closed rockcavera closed 6 months ago

rockcavera commented 6 months ago

x32 and x64 binaries for windows are both x64.

arnetheduck commented 6 months ago

ok weird. I don't really know how to make an x32 one then - copied this from nimble - do you?

rockcavera commented 6 months ago

ok weird. I don't really know how to make an x32 one then - copied this from nimble - do you?

In fact, nimble has the same problem.

I don't have enough knowledge in github actions, but some things I noticed:

The current problem, at least what it seems like, is that actions runs on an amd64 machine and nimble installs Nim according to that architecture.

I believe using setup-msys2 is sufficient to compile for x64 and x32 on Windows.

arnetheduck commented 6 months ago

Ok, I'm happy to take a patch for this, but for now the solution is to remove it: https://github.com/arnetheduck/nph/commit/4dc499888ee4bca166f6cd73a801839177ab8845