Some smaller changes.

[jochumdev]

3 patches i wrote for you great network formula:

• a way to add/remove packages trough network.packages
• some more known interface values.
• add a way to edit dhclient.conf via network.interfaces

[jochumdev]

Hi, yeah salstack-tools could make the same as network.packages, but i like it to have everything at the right place what do you think about it?

[arnisoph]

Normally I would say preventing code duplication is a good thing. Do we have technical reasons to depend on pkg mgmt in the network formula?

[jochumdev]

This way i know that these packages will be installed/removed because of networking stuff. It looks a way better in the pillar.

network:
  {%- if salt['grains.get']('os_family') == 'Debian' %}
  pkgs:
    purged:
      - resolvconf
    installed:
      - openvswitch-switch
  {% endif -%}

  interfaces:
    - name: eth0
      proto: dhcp
      type: eth

Maybe rename network:pkgs to network:packages ?

[arnisoph]

AFAIR you're accessing master's grains not the minion's grains. https://github.com/bechtoldt/saltstack-tools-formula should be able to manage this.

[jochumdev]

Hey @bechtoldt your sure about master's grains?

[jochumdev]

Hey Arnold, do you commit that? :)

[arnisoph]

@pcdummy could you please remove package mgmt from https://github.com/bechtoldt/saltstack-network-formula/blob/master/network/interfaces.sls#L60 to prevent duplicated code?

[arnisoph]

ping @pcdummy :)