search

arniu / react-native-ionicons

Ionic icons for React Native
MIT License
42 stars 11 forks source link

Ionicons v5 #16

Open arniu opened 4 years ago

arniu commented 4 years ago

Generated ttf file

https://github.com/ecdo/ionicons

Create SVG files to ttf font

目前遇到的问题

使用 svgicons2svgfont 转换，结果 add 等无法显示

arniu commented 4 years ago

@JacksonLaw Would you mind reviewing the code? Thanks very much.

JacksonLaw commented 4 years ago

Yes, they're all generated by the script. So, there is no need to track it.

I see, sorry my knowledge is limited. I can not see any other issues.

humatic commented 4 years ago

Are you sure this is working correctly? I installed the package here and I can get icons to render using the <Icon> tag, but there is something bizarre going on. For example, when I do <Icon name="star-half-outline" size={40} color="#000000" /> I get an rendering like this: Screenshot_20200405-114853_2 This is not correct (see the star-half-outline at ionicons.com). There is some sort of inversion going on.

humatic commented 4 years ago

Separate issue. I had to manually load the Ionicons.ttf file using Font.loadAsync(...) (using Expo).

arniu commented 4 years ago

Are you sure this is working correctly? I installed the package here and I can get icons to render using the <Icon> tag, but there is something bizarre going on. For example, when I do <Icon name="star-half-outline" size={40} color="#000000" /> I get an rendering like this: Screenshot_20200405-114853_2 This is not correct (see the star-half-outline at ionicons.com). There is some sort of inversion going on.

Thanks very much.

blazebarsamian commented 4 years ago

@arniu is there any updates on this PR?

I installed this package on a project and theres a few issues. I really want to be able to use this icon set but I cant if the outline icons arent working and some icons arent even visible.

And before you suggest using version 4, I specifically need icons that were added in version 5.

a-mazalov commented 4 years ago

@arniu will this PR be accepted?

arniu commented 4 years ago

I'm stuck on generating ttf font...

seyedasfar commented 3 years ago

Here we have the TTF font https://github.com/oblador/react-native-vector-icons/blob/master/Fonts/Ionicons.ttf