search

arniu / react-native-sparkline

An ART-based sparkline component for react-native
MIT License
19 stars 7 forks source link

Screenshots Please #13

Closed Noitidart closed 6 years ago

Noitidart commented 6 years ago

May you please add screenshots (ideally GIF) of this in action in readme? That's the first thing a lot of RN package searchers do. There are so many packages its not easy to (1) install each one, (2) then render it respecting properties, (3) then uninstall it if it doesn't fit.

arniu commented 6 years ago

Sorry, I'm really too busy to do it. Would you like to add some? Maybe we together can make it an awesome library 😄

Noitidart commented 6 years ago

I haven't used this yet, as I don't know what it really offers without seeing pictures. But sure ok, when I get some time, I'll install it and try to use it per Readme, I'm not sure what the end result is supposed to look like. Will screenshot what I get.

vijayst commented 6 years ago

I will be interested to help you out with this. Does it work for Android as well?

arniu commented 6 years ago

@vijayst Yes! Thanks very much 😄

vijayst commented 6 years ago

Screenshot for iOS simulator screen shot - iphone 8 - 2018-04-21 at 06 41 04

arniu commented 6 years ago

@vijayst Awesome! Can you make a PR to add this screenshot? Thanks very much.

vijayst commented 6 years ago

ok sure, I will do a PR. And android screenshot is screenshot_1524275476

vijayst commented 6 years ago

Added PR!

Noitidart commented 6 years ago

Thanks so much @vijayst !