arnoappenzeller / PiPifier

PiPifier is a native macOS 10.12 Safari extension that lets you use every HTML5 video in Picture in Picture mode
MIT License
756 stars 60 forks source link

Adding native/custom PiP buttons to popular sites #12

Open arnoappenzeller opened 7 years ago

arnoappenzeller commented 7 years ago

2d783e04d24d9e6e28d7de48bd65b650c0bbfb54 adds the possibility to enable custom PiP in the video player of popular pages. This option is enabled by default since I find the inline PiP much more useful.

One major advantage is that this doesn't require any other interaction that you would need for autoplaying video players.

At the moment this feature only supports Youtube.

Here is an updating list of video players that are supported/deprecated(because they added their own button)/wished:

If you have any player you want to see supported don't hesitate and I add it to the wishlist

RvMouche commented 7 years ago

A native player in videoJS players would be neat

arnoappenzeller commented 7 years ago

Should be possible but there needs to be a clever way to detect the videoJS players because currently the native placement works via the domain.

arnoappenzeller commented 7 years ago

365c03b2b9da6624aa4dded92a508345304b96e9 adds basic support for video.js players.

But I'm lacking a bit of real world examples. @RvMouche do you have some maybe?

kwokaaron commented 7 years ago

Slightly off-topic, but wanted to check the feasibility of this first. I was wondering with the addition of the custom PiP buttons in the video players on popular pages, is it possible to provide an option to disable this feature as well in the extension settings?

arnoappenzeller commented 7 years ago

The main app has an option to disable it so if a problem would occur this would be a workaround till a fix bildschirmfoto 2016-10-18 um 20 54 39

kwokaaron commented 7 years ago

Ah sorry about that, I only checked to see if there was an option to do this in the Safari preference 'Extensions' tab. Thanks!

arnoappenzeller commented 7 years ago

Don't worry I wanted to add it there in the first place but it seems not possible anymore with the new Safari Extension API

kwokaaron commented 7 years ago

Got it. Got slightly confused since my old extensions previously installed in Safari still shows this.

kwokaaron commented 7 years ago

There seems to be a bug where it reappears. It seems to work on the very first page load, but refreshing the youtube video page seems to show the button again. Should I make a new issue for this?

arnoappenzeller commented 7 years ago

Did you disable it and then it reappears?

kwokaaron commented 7 years ago

Yes. I've even tried uninstalling it and deleting all the containers.

arnoappenzeller commented 7 years ago

This should be considered as a bug and is noted in issue #15

akeonline commented 7 years ago

Hi, am using JW Player (flash) on streamtvbox website, but the button doesn't seem to appear to be able to click it, I've tried pausing and playing, nothing seems to work? Any help would be greatly appreciated, thanks.

arnoappenzeller commented 7 years ago

Flash is not supported by PiP mode in Sierra so this is not possible. Also this is not the right issue for it so I'll clean this up in a bit

ghost commented 7 years ago

Maybe outdated, but unfortunately some websites still use Silverlight (by Microsoft). I'm just wondering if it would be possible to see PiPifier supporting those videos in some future update?

PS: Just downloaded it from the AppStore and I'm quite happy with it. Thanks!

arnoappenzeller commented 7 years ago

@WillyH93 unfortunately PiP on Sierra supports only HTML5 videos. So Silverlight can't be supported at the moment

WilliamBlais commented 7 years ago

Would be awesome to add Udemy.

JoniVR commented 7 years ago

@WilliamBlais As far as I'm aware, it already supports Udemy, for me the button is on the bottom left next to play screenshot

tonycoco commented 7 years ago

What about Facebook?

adavidzh commented 7 years ago

I was wondering about support for RTP since that uses the HTML5 Radiant Media Player.

olliebaum commented 6 years ago

So, it's not strictly a video player... but would it be possible to add support for Tumblr TV. I like to have GIFs playing in the background while I work. Would be neat to have it in PiP.

floriandierickx commented 6 years ago

To add to the wishlist: THEOPLayer would be nice. It is used by vualto, .. to stream NBC, CNN, Vrt (belgian public broadcasting), ...