Open whbassignani opened 7 years ago
+1. You can click the button but nothing happens.
Same problem for me. Worked once and then never again.
Same issue. @whbassignani's fixed worked.
Yeah, it doesn't work for Twitch. Wild guess: it might have something to do with the Twitch player having its own kinda "PiP" mode once you scroll down on a page.
Edit: I'd really appreciate a fix. :-)
I don’t think it’s that Twitch has their own PiP; that launches a regular embed in a new window.
I think that Twitch changed the markup structure to bury the video tag further down the tree. Pipifier is merely not finding it’s new location.
On Jan 22, 2017, at 8:43 AM, Felix Förtsch notifications@github.com wrote:
Yeah, it doesn't work for Twitch. Wild guess: it might have something to do with the Twitch player having its own kinda "PiP" mode once you scroll down on a page.
— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub, or mute the thread.
I don't know if you guys know, but you need to pause and play the stream at least once for the PiP button to work. I've been using PiP and Twitch for ages now. It's specified in the App Store description, and you have to do the same for each auto-play videos.
Definately not working on twitch even if you play and pause the video
One thing that made it work was to open Web Inspector, drag the node to an outer div (two or three levels), and then try it. Not sure if that helps?
Just reporting in that as OP said, this is the only thing that works for me.
Add this as a bookmark called "PiP" (or whatever you want to call it): javascript:document.querySelector("video").webkitSetPresentationMode("picture-in-picture");
.
It consistently works for Twitch and anything else, and as far as I can tell, obviates the need for an extension like this.
Yeah, it appears the use of javascript:document.querySelector("video").webkitSetPresentationMode("picture-in-picture");
as a bookmarklet works in Safari currently while using document.querySelector("video").webkitSetPresentationMode("picture-in-picture");
via Safari's console does not (though it does start working if you were to initiate the bookmarklet previously).
It seems like there's a permission issue happening here with Safari.
I'm considering this as a more universal issue (rather than just being related to Twitch) as discussed here: https://github.com/arnoappenzeller/PiPifier/issues/37
As an aside, this extension does more than just trigger that PiP command so it would be nice of this were to be fixed.
I'm finding it crashes every day:
I can send the crash report too if needed. This happens with Safari 10.1.2when watching twit.tv
Never seen so many crash logs... Can you attach one or two of the logs?
Yes, will do, but this is on 10.12.6 beta 4 so have NDA and can't say much more (I'm a dev and beta tester).
Here is the most recent.
On Jun 21, 2017, at 19:45, Arno Appenzeller notifications@github.com wrote:
Never seen so many crash logs... Can you attach one or two of the logs?
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/arnoappenzeller/PiPifier/issues/24#issuecomment-310040816, or mute the thread https://github.com/notifications/unsubscribe-auth/AMc5B9rhdE98OHJIrAO9CaWO6ZXO7hR9ks5sGPRAgaJpZM4K6JLn.
Thanks. I will look into it but since it happens on a beta I think I'll rather wait and see what the final version brings
GM in 3 to 4 weeks is the word.
Anyhow thanks for a great little application.
R
On Jun 21, 2017, at 19:56, Arno Appenzeller notifications@github.com wrote:
Thanks. I will look into it but since it happens on a beta I think I'll rather wait and see what the final version brings
— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/arnoappenzeller/PiPifier/issues/24#issuecomment-310043152, or mute the thread https://github.com/notifications/unsubscribe-auth/AMc5B-kJo8gi1er8gKuYBn1KDescu-Ubks5sGPbugaJpZM4K6JLn.
Works fine if you use twitch.tv site's "pop out window" and then click the PiPifier button in Mac OSX 10.13.1 on Safari 11.0.1
Hello, the issue isn't still closed and it's good because I got it in 2023. Any comments?
I got the Twitch.tv video player to work with Pipifier, but after that first fluke it stopped working.
The button is disabled about half the time, and the other half it works but nothing happens on click.
One thing that made it work was to open Web Inspector, drag the