search

arnoappenzeller / PiPifier

PiPifier is a native macOS 10.12 Safari extension that lets you use every HTML5 video in Picture in Picture mode
MIT License
756 stars 60 forks source link

Memory leaks #28

Closed DanielO closed 7 years ago

DanielO commented 7 years ago

This (very useful :) extension seems to cause Safari Web Content processes to leak memory (rather badly). For example after a day or so I find some of those processes using 4 to 15 (!) GB of memory.

This doesn't seem related to actually using the extension but it's hard to be sure since Safari Web Content processes are shared between web pages :-/

ncovercash commented 7 years ago

If you would look in the hidden Debug menu of Safari, it may be able to shed some light on what is going on. Enable this menu item with the following terminal command:

defaults write com.apple.Safari IncludeInternalDebugMenu 1
arnoappenzeller commented 7 years ago

Hmm I cannot see the same behaviour when running PiPifier. Do you have an example page where this is happening?

DanielO commented 7 years ago

It happens most frequently with https://app.asana.com but that is a paid service, so.. I do see it on twitter.com sometimes but not right now.

This one is agrab after it was running over night 4 14gb

And this one just after I killed it and it reloaded 312mb

The overnight was was reporting it was using 4.14GB of memory in activity monitor, after reload 312MB.

ncovercash commented 7 years ago

Definitely a leak, with all that bmalloc usage...I don't know how to fix this, but im sure there is a way to

DanielO commented 7 years ago

I updated to the git version and can no longer repro this so I'm closing it.